Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932391AbbLRNmR (ORCPT ); Fri, 18 Dec 2015 08:42:17 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:37313 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932320AbbLRNmO convert rfc822-to-8bit (ORCPT ); Fri, 18 Dec 2015 08:42:14 -0500 X-IronPort-AV: E=Sophos;i="5.20,446,1444662000"; d="scan'208";a="202108956" From: Phil Edworthy To: Wolfram Sang CC: Simon Horman , Bjorn Helgaas , Geert Uytterhoeven , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-sh@vger.kernel.org" Subject: RE: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar Thread-Topic: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar Thread-Index: AQHROM4m9nRzodEPBkeH5670ym6BC57PLLcAgAGTswA= Date: Fri, 18 Dec 2015 13:42:08 +0000 Message-ID: References: <1450358557-28376-1-git-send-email-phil.edworthy@renesas.com> <1450358557-28376-3-git-send-email-phil.edworthy@renesas.com> <20151217133058.GA20372@katana> In-Reply-To: <20151217133058.GA20372@katana> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=phil.edworthy@renesas.com; x-originating-ip: [193.141.220.21] x-microsoft-exchange-diagnostics: 1;PS1PR06MB1180;5:eBYZoXp6/FiFEB62q7emGH266H9mN9qJEB2Dh8tP80P5ho8AJZl1PtNO/lrk/V9/scOIgtv9sWdkGF9515pFRsEeY2oJfNZrrS3gqBAAvxnjsA5nbqlRvk2SXzHIP3CBBz/5w/irI8r8AuHVxIrS/g==;24:tsNYn/lYzyBuXLUQIcAG+FA302xdcY6MGBFslTeJcAUaTzsUNy66JEob/zE6pE9Dmg7diW5+T9wknxT6APuHeGccZmZFg5MwENxrHIBUFpI=;20:q/xUmPieso5UEsqm9NYtiOtZa71wm8YfypIKvxN8zNoFmyfty38VpzwCUWXOqR+godGM6XjTtRAqw2Wv+LuGPHWPBqOhemy1oMNuKOvyaoGdtXP9kUG6Rag7GDUDbXMukQP34EzmUSHh9f6GChRG3ijCSeC5IAOqOUBQSxnxNQ4= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1180; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501046);SRVR:PS1PR06MB1180;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1180; x-forefront-prvs: 07943272E1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(24454002)(199003)(1220700001)(189998001)(1096002)(10400500002)(5004730100002)(77096005)(11100500001)(5008740100001)(105586002)(106356001)(40100003)(106116001)(50986999)(92566002)(101416001)(2900100001)(2950100001)(76576001)(33656002)(122556002)(110136002)(81156007)(6116002)(76176999)(3846002)(586003)(66066001)(97736004)(5003600100002)(102836003)(5002640100001)(5001960100002)(54356999)(86362001)(74316001)(87936001);DIR:OUT;SFP:1102;SCL:1;SRVR:PS1PR06MB1180;H:PS1PR06MB1180.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2015 13:42:08.7523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB1180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 671 Lines: 24 Hi Wolfram, On 17 December 2015 13:31, Wolfram Sang wrote: > Hi Phil, > > > + /* Wait until we are in L1 */ > > + while (!(val & L1FAEG)) > > + val = rcar_pci_read_reg(pcie, PMSR); > > No timeout? Since the hardware doesn't support hot plug, I believe this loop will always exit very quickly. Unless someone has taken a hammer to the HW of course. However, point taken. I'll add a timeout. > Regards, > > Wolfram -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/