Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932430AbbLRNn3 (ORCPT ); Fri, 18 Dec 2015 08:43:29 -0500 Received: from relmlor4.renesas.com ([210.160.252.174]:19251 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752941AbbLRNn0 convert rfc822-to-8bit (ORCPT ); Fri, 18 Dec 2015 08:43:26 -0500 X-IronPort-AV: E=Sophos;i="5.20,446,1444662000"; d="scan'208";a="202108981" From: Phil Edworthy To: Wolfram Sang CC: Simon Horman , Bjorn Helgaas , Geert Uytterhoeven , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-sh@vger.kernel.org" Subject: RE: [PATCH 4/4] PCI: rcar: Add Gen2 PHY setup to pcie-rcar Thread-Topic: [PATCH 4/4] PCI: rcar: Add Gen2 PHY setup to pcie-rcar Thread-Index: AQHROM4w76Ampro4/0GnlDdSngszXp7PLVIAgAGU4dA= Date: Fri, 18 Dec 2015 13:43:21 +0000 Message-ID: References: <1450358557-28376-1-git-send-email-phil.edworthy@renesas.com> <1450358557-28376-5-git-send-email-phil.edworthy@renesas.com> <20151217133308.GB20372@katana> In-Reply-To: <20151217133308.GB20372@katana> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=phil.edworthy@renesas.com; x-originating-ip: [193.141.220.21] x-microsoft-exchange-diagnostics: 1;PS1PR06MB1180;5:mfD7jJTAZHRHQwiT8clMNkczoGUDHRC3g6Q+P4X/NpmHXWHy3PfnH+4lEPM6MQy5/xQLVyiTocFzcWHeQ9rdV4WbdNHXHnTJu1259y5MRVu925C/5wvmQBw0ZQp5GRlAqbnkhzG/VbFCGy7O99tVwg==;24:qsJ40eDjNFEgmO9Mcw5gyalM9aAODCnir6a6xFOSnu6e6adlqdkkS7rmPXTlXgb8C93lVgYjZQ4M7/MD+kiMyS1a4eZ9Zh+bZ28FX6Zz44g=;20:M3HHLYKcHlW/x0R9akGgBH/z5x9M4tvWq7jbzoG64pYEtqzV6d5O0g9UuvElYWmpw8n+9rb/+BPR8Q9CuUHKPIjEoF23Kgvk7vsc/3Lwzq8jwIrufz+LIIyAsqG+KVD7hdHSmuz/HXt/Vxe+gbHaR1fD0rmpmLwsknpkdXsDZKg= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1180; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501046);SRVR:PS1PR06MB1180;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1180; x-forefront-prvs: 07943272E1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(24454002)(199003)(1220700001)(189998001)(1096002)(10400500002)(5004730100002)(77096005)(11100500001)(5008740100001)(105586002)(106356001)(40100003)(106116001)(50986999)(92566002)(101416001)(2900100001)(2950100001)(76576001)(33656002)(122556002)(110136002)(81156007)(6116002)(76176999)(3846002)(586003)(66066001)(97736004)(5003600100002)(102836003)(5002640100001)(5001960100002)(54356999)(86362001)(74316001)(87936001);DIR:OUT;SFP:1102;SCL:1;SRVR:PS1PR06MB1180;H:PS1PR06MB1180.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2015 13:43:21.6455 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB1180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 25 Hi Wolfram, On 17 December 2015 13:33, Wolfram Sang wrote: > > + rcar_pci_write_reg(pcie, 0x000f0030, GEN2_PCIEPHYADDR); > > + rcar_pci_write_reg(pcie, 0x00381203, GEN2_PCIEPHYDATA); > > + rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL); > > + rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL); > > + > > + rcar_pci_write_reg(pcie, 0x000f0054, GEN2_PCIEPHYADDR); > > + /* The following value is for DC connection, no termination resistor */ > > + rcar_pci_write_reg(pcie, 0x13802007, GEN2_PCIEPHYDATA); > > + rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL); > > + rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL); > > I'd vote for a comment saying where these magic values come from, i.e. > which manual, which chapter, etc... Ok, will do. Thanks Phil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/