Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932554AbbLRNoN (ORCPT ); Fri, 18 Dec 2015 08:44:13 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:44370 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932469AbbLRNoJ (ORCPT ); Fri, 18 Dec 2015 08:44:09 -0500 X-IronPort-AV: E=Sophos;i="5.20,446,1444662000"; d="scan'208";a="200864499" From: Phil Edworthy To: Geert Uytterhoeven , Wolfram Sang CC: Simon Horman , Bjorn Helgaas , "linux-kernel@vger.kernel.org" , linux-pci , Linux-sh list Subject: RE: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar Thread-Topic: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar Thread-Index: AQHROM4m9nRzodEPBkeH5670ym6BC57PLLcAgAAC4ACAAZLxIA== Date: Fri, 18 Dec 2015 13:44:04 +0000 Message-ID: References: <1450358557-28376-1-git-send-email-phil.edworthy@renesas.com> <1450358557-28376-3-git-send-email-phil.edworthy@renesas.com> <20151217133058.GA20372@katana> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=phil.edworthy@renesas.com; x-originating-ip: [193.141.220.21] x-microsoft-exchange-diagnostics: 1;PS1PR06MB1180;5:lbtHyhHT+GLoFc7OI1YPYxfB9C0CfadH7nWvSpCMBF/iQuyXW3T03leVPreyZXkb1rG4NxONkhlFyLAHQsychA09L99xQBbWcYC5GeW2ndMreoT2DdHbdJ5Aul4VqJqL9bZAtnJxrJ0cCByvxG/GIw==;24:GuEcMtn6btXWYUWtICZ7sTWwg3tsdZnrtly9YAhkiH5dS8SyBMCgWHA7arMjeju5fznvZFzHTANkEOx3xMsD5pKZV/K9m2Q7rM5+GJEyvsI=;20:sSlT44LI5GJUquGQetygWhFK8lllQxIY8HavlOQd2XWv6TAtN+NTr3H0DKhaKWF6Pk9UEAjLF7WkU07l6lV6nV1z5bp9/6Kk1sPb3qh1A3SgoOUQXUgj5awq010j2/mgnBOm//KwTyHPsBO/+9vLRHuva+rKbUURoOLSwPGSc4M= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1180; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501046);SRVR:PS1PR06MB1180;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1180; x-forefront-prvs: 07943272E1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(189002)(24454002)(199003)(1220700001)(189998001)(1096002)(10400500002)(5004730100002)(77096005)(11100500001)(5008740100001)(105586002)(106356001)(40100003)(106116001)(50986999)(92566002)(101416001)(2900100001)(2950100001)(76576001)(33656002)(122556002)(19580395003)(93886004)(81156007)(6116002)(76176999)(3846002)(586003)(66066001)(97736004)(5003600100002)(102836003)(5002640100001)(5001960100002)(54356999)(5001770100001)(19580405001)(86362001)(74316001)(87936001);DIR:OUT;SFP:1102;SCL:1;SRVR:PS1PR06MB1180;H:PS1PR06MB1180.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2015 13:44:04.6939 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB1180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tBIDiHnR024438 Content-Length: 906 Lines: 26 On 17 December 2015 13:41, Geert Uytterhoeven wrote: > On Thu, Dec 17, 2015 at 2:30 PM, Wolfram Sang wrote: > >> + /* Wait until we are in L1 */ > >> + while (!(val & L1FAEG)) > >> + val = rcar_pci_read_reg(pcie, PMSR); > > > > No timeout? > > And no cpu_relax() in each iteration. Sure, I'll fix that. Thanks Phil > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?