Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932355AbbLRNtU (ORCPT ); Fri, 18 Dec 2015 08:49:20 -0500 Received: from mail-bl2on0055.outbound.protection.outlook.com ([65.55.169.55]:18688 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752753AbbLRNtS (ORCPT ); Fri, 18 Dec 2015 08:49:18 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Fri, 18 Dec 2015 16:48:55 +0300 From: Yury Norov To: Arnd Bergmann CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 15/20] arm64: signal: move ilp32 and lp64 common code to separated file Message-ID: <20151218134855.GA31200@yury-N73SV> References: <1450215766-14765-1-git-send-email-ynorov@caviumnetworks.com> <1450215766-14765-16-git-send-email-ynorov@caviumnetworks.com> <6089723.moZBJ98Dq4@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6089723.moZBJ98Dq4@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: VI1PR02CA0031.eurprd02.prod.outlook.com (25.162.7.169) To BY2PR07MB616.namprd07.prod.outlook.com (10.141.222.156) X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB616;2:5AJOYJw9+MLYl6vU9Ca3z8O+8pxooyJ80hJUPTvi/oQG+d/3b9mHrLKnUFDB+qj0QHllZj71uqXzykwOuJ3/dlpiN7Lno5IbIEySOTXIFyYSBoiuM0HQv+KXVIjiNbxtM0ju9/FnNB1/vmngFoysRg==;3:nTjrdXQeEPkTzKIj6JE6IM5BUxnnskSHnbsWf3eLW7eGZJwyoyKppzgGOqKa2ilJfBXgBq+s/ufNJ6tx82l7ZnLaUStzT2E3OAMPi0X4deVmQlzTES3xFB7BT1cR5uKb;25:TAq0pCk0uQMKxEMnVpFZj/CyWccP+r1qZ8LO8BVOGWO01gp1zqFYoLWj0xaHHixJvzjleJHXJb2qpTvUpT16mYfiS4h3yQ1JVOIBnVp56A2ZndYB3Cl/f47VawO2yEECMy0yMg+Bew6kv0NqQviarTeWeKnPcR1V5YSLWMYagCyNqfyeFzPApF+oe2PAr7aGKABdC5PiDOpVuTgh4xxxD6tyt39n08oE20p0fgsFBELT2viOyPHYJCHE4sXEFfG2cnhKmD/MbnPUmyjH5kSdYg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB616; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB616;20:tazdewNbZ54fspYua9QN6gSttMLE24TUTXhg/CrGUm2x5eYxtQmWmQ15MAX/gUlwY3C+AcFLkNUeEmg6RqzlrX3eTd1AoJHdclzU5TVLzM419fvT2X103pG//+LR4El0A7rhpXG324h+2wyJJsCxk+fKsTqzwYL1Pu8a49dgNlvcCBtnXWjP6yFEVN1M0kTY7YREtojxVkXQ/X9pXy7GR+T72HOwIO8Z5PUmT4Wv6zO1i4bD1fMh4YZC64Msc1p8k88mdlK3cr7MVvOAmvU8kQZFObzcceuNyOqQcCdD24K95WljUmQyVPDTqRV5G5n8UzadfnPUeLd0FW4nzLdB1mVmNCNuyGI9BTpo5Y549xBK1XQWq1oJ0TzeHifqHuV/RtXX05Ktfr7KTiwil1Uw7Yjr/AyhUwOi+dhoBzwms+hNsBR5BD2jcan98PWgbjWjmN9wyvCEW14D66VacuNE6l79qseiK0kuKTsmATBnTeo0vF2op94uvFWG8eC1M6926547OJMp4gt8wkiNwB4HW86UKez6+jvQm3TbuF+0DLTDY8HNAZuuYfq6OLy+/ETtm1YKBGMvTZS3ivHhsxyTIw1c499hm7hku3LY8Dn+BE4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046);SRVR:BY2PR07MB616;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB616; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB616;4:/5jEwX1lm4kXkRqYL0G5ZGziyzL5+/MbFKRGG5m/JMR+Od/Wgo65sIahhDRSnGsd6aO8r4Cw8OlVfu80eLFKRl8ZBjUwYvvBIzN6PCgQxd7QcDjvsWvIF310JAUjgF68gPSLIIAZ8C+axvkHaXq5tatGWcgOJrPDIX0wREaFszQhYOoLSJ6BFnDFnIZonET/hINbP0PDZjcZ+zfT3CmsC6mNeXjOsHIFojQyWk55QJCyIEqXb3X6dKro/cey+28LhEaN/fj/izlnV0/B31GSLBJJb+FegfLNPSS1ncpjPyGbWnetLVxPRNCUN51CWsaE1D2l94Ji9mTZtoIKXaIbhxOymt3floK0k+P8UN8nbu3+TjKomb3mPFgjMdYGVxJA X-Forefront-PRVS: 07943272E1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(189002)(199003)(24454002)(42186005)(3846002)(76506005)(33656002)(6116002)(50986999)(1076002)(87976001)(23726003)(586003)(50466002)(106356001)(97756001)(66066001)(76176999)(77096005)(54356999)(1096002)(19580395003)(92566002)(47776003)(5004730100002)(2950100001)(122386002)(5008740100001)(46406003)(105586002)(83506001)(5001960100002)(110136002)(101416001)(33716001)(81156007)(97736004)(4001350100001)(40100003)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR07MB616;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR07MB616;23:/EofOB96Gw/8y7E+dOG9uJJJI4iNANo5TO69bmL8c8?= =?us-ascii?Q?iSrKWB4kXGzPSPKXD7Rnmp90FjS9S+QJpGnNip5z3uMMFz34WMMaGZoQQCtV?= =?us-ascii?Q?6s0D8XPkvlE3wn5y5aZbjlxlw5t0Lr1hrGIfggUF6cjCdbwLtaFdvrF8rD2+?= =?us-ascii?Q?zR2VOEQ+rMh8bGy5JHnyYZ/87y1EzLBuBWSyveQ1tzjorJSy3aJc3CXNy5u1?= =?us-ascii?Q?kSx3LnR2tK/ifsFPzSGnmxTjA5FfUUqcAP1v3pRVVNy4gAdVLorPNBYOZa8b?= =?us-ascii?Q?1NyuX+BhExWur1A+2QCpjj9LanxuXhCVZlY+yyGp2CEFzVWXf4W/91euD2jb?= =?us-ascii?Q?1ZQWXw49bQPEM/d+cI0bvuNeKRXNsOOB0B/pgYhjJ7lK+tzA4pHSx2TgdUfk?= =?us-ascii?Q?Zu1z06/3jLR33FXIDPb/tIdCtAaB0y8WQxXQJQ5JjUj8CBPAY4S6tu0e4saD?= =?us-ascii?Q?E/f1ElQm/siOZx9ZIgu4gJexkP5IxVuBhB7OOdO0HomaunKxxxslRLewdRLg?= =?us-ascii?Q?xftMXruqsX0fKB3egczURwYxDASdwtsY+ngbv9rvmpxpHnhz2HdVQyL+mz9H?= =?us-ascii?Q?zmrHI0YY2ww8Hc5X7lOEQc+em4NlEAgfbck6Vnpj8rvIvmkAv6SAyGPkD5yz?= =?us-ascii?Q?Z5mG1E/yETRRGD75sH623nIwCKd505U5eAsQtyllYkrsuruHAWMY84MbBOI8?= =?us-ascii?Q?x46+eQxJ+sNQ7zvgpZCwt8p0Yr2dKg+QVu2qWw/T9AjYErDn7j1IzKrBoVm3?= =?us-ascii?Q?uYAAC9T18WNvAqwa7/0gOc16LGL+4UjnOqQaF6nbUN4zJbk6iXuaZYF7KUiF?= =?us-ascii?Q?wI+O3d5zp9RuR5sjU0ZT0SDalfITlzw7GKd+2E0bfb2i6JB4TXK9HTIuyBNo?= =?us-ascii?Q?NVKA639htEBTnNCOSyL9yS1Dp87bkIYKhbI0AN0QHPiBl7kV0Vs1wcR2JCp5?= =?us-ascii?Q?WvGtpeguax5WyM1/8DJRsi3140yLJYik5DYtXx6rlwAXVfO+wi9SW3KHqm78?= =?us-ascii?Q?8xsAIMnul8iyiX24ue1zagdD1U7dcdWutwOcqRZp9rFeengw+4rPRbZVmqqq?= =?us-ascii?Q?O5knkRFKTpuhCcuJ5Sg75rChZxbozg+bcOUpl+piVkHBp4mQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB616;5:mZoZIqlAMQM2sFzv9LgLbnuvUWUVUqoqAYDlnSPURbPApVmzmCUn90RrmkRS3ltVTg3cB289Jbid9UgN84vierHij+Sit4IrLAbl0Ptt9k2v+HOEd4+Gnb16EHblhezKrrZdh1YnKxt7knjk4S0Cxg==;24:5x2crXxL4TOy8ri9ZafHkNioHvE3oQwNM9I0ruM1xdFQ8ViB0UpB8Ak9cX6hj6xQ42SRbTJXhUmm3hlrZqlrRE+YQ7npq+gXbaTh3jQSpkk= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2015 13:49:15.7880 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB616 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 25 On Wed, Dec 16, 2015 at 05:08:35PM +0100, Arnd Bergmann wrote: > On Wednesday 16 December 2015 00:42:41 Yury Norov wrote: > > + sigtramp = ka->sa.sa_restorer; > > +#ifdef CONFIG_ARM64_ILP32 > > + else if (is_ilp32_compat_task()) > > + sigtramp = VDSO_SYMBOL(current->mm->context.vdso, sigtramp_ilp32); > > +#endif > > + else > > + sigtramp = VDSO_SYMBOL(current->mm->context.vdso, sigtramp); > > > > This is another case where I think it's more readable to remove the #ifdef, > with no change in behavior. > > Arnd No actually. symbol sigtramp_ilp32 is declared in arch/arm64/kernel/vdso-ilp32/vdso-ilp32.lds.S And so it does not exist if CONFIG_ARM64_ILP32 is not set. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/