Date: Fri, 18 Dec 2015 16:57:17 +0300
From: Yury Norov <ynorov@caviumnetworks.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: <linux-arm-kernel@lists.infradead.org>, <catalin.marinas@arm.com>,
        <linux-kernel@vger.kernel.org>, <pinskia@gmail.com>,
        <Prasun.Kapoor@caviumnetworks.com>, <schwab@suse.de>,
        <broonie@kernel.org>, <Nathan_Lynch@mentor.com>, <agraf@suse.de>,
        <klimov.linux@gmail.com>,
        Andrew Pinski <Andrew.Pinski@caviumnetworks.com>,
        <jan.dakinevich@gmail.com>, Andrew Pinski <apinski@cavium.com>,
        <ddaney.cavm@gmail.com>, <bamvor.zhangjian@huawei.com>,
        <philipp.tomsich@theobroma-systems.com>, <joseph@codesourcery.com>,
        <christoph.muellner@theobroma-systems.com>
Subject: Re: [PATCH v6 10/20] arm64:ilp32 use the native LP64 'start_thread'
 for ILP32 threads
Message-ID: <20151218135717.GC31200@yury-N73SV>
References: <1450215766-14765-1-git-send-email-ynorov@caviumnetworks.com>
 <1450215766-14765-11-git-send-email-ynorov@caviumnetworks.com>
 <12007390.0rtOQc0npd@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <12007390.0rtOQc0npd@wuerfel>
User-Agent: Mutt/1.5.23 (2014-03-12)
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2015 13:57:48.0624 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR07MB610
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 810
Lines: 22

On Wed, Dec 16, 2015 at 04:50:18PM +0100, Arnd Bergmann wrote:
> On Wednesday 16 December 2015 00:42:36 Yury Norov wrote:
> > +#ifdef CONFIG_ARM64_ILP32
> > +       /* ILP32 threads are started the same way as LP64 threads. */
> > +       if (is_ilp32_compat_task()) {
> > +               start_thread(regs, pc, sp);
> > +               return;
> > +       }
> > +#endif
> > 
> 
> Just a small style comment, but I think you can just leave out the #ifdef,
> as is_ilp32_compat_task() will already return false if that is disabled.
> 
> 	Arnd

Missed it, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/