Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752837AbbLRPCl (ORCPT ); Fri, 18 Dec 2015 10:02:41 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36045 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbbLRPCh (ORCPT ); Fri, 18 Dec 2015 10:02:37 -0500 From: Minfei Huang To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, mhuang@redhat.com, Minfei Huang Subject: [PATCH 2/2] bio: Free own bvec before assigning the source bio's bvec Date: Fri, 18 Dec 2015 23:02:32 +0800 Message-Id: <1450450952-18565-2-git-send-email-mnfhuang@gmail.com> X-Mailer: git-send-email 2.6.3 In-Reply-To: <1450450952-18565-1-git-send-email-mnfhuang@gmail.com> References: <1450450952-18565-1-git-send-email-mnfhuang@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 40 This is a memory leaking during splitting the bio by the caller bio_clone_fast. Clone bio may allocate its own bvec, if demanding bvec is more than inline bvec in function bio_alloc_bioset. bi_io_vec is assigned to the source bio's bvec directly without freeing it firstly in function __bio_clone_fast. To fix it, freeing the own bvec firstly before assigning the source bio's bvec. Signed-off-by: Minfei Huang --- block/bio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/bio.c b/block/bio.c index 70d9814..b24fd6e 100644 --- a/block/bio.c +++ b/block/bio.c @@ -581,6 +581,10 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src) bio_set_flag(bio, BIO_CLONED); bio->bi_rw = bio_src->bi_rw; bio->bi_iter = bio_src->bi_iter; + + if (bio_flagged(bio, BIO_OWNS_VEC)) + bvec_free(bio->bi_pool->bvec_pool, + bio->bi_io_vec, BIO_POOL_IDX(bio)); bio->bi_io_vec = bio_src->bi_io_vec; } EXPORT_SYMBOL(__bio_clone_fast); -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/