Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932760AbbLRQHH (ORCPT ); Fri, 18 Dec 2015 11:07:07 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:33568 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbbLRQHE (ORCPT ); Fri, 18 Dec 2015 11:07:04 -0500 Subject: Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM To: Sebastian Frias References: <5672D89A.4090307@laposte.net> <5672F9C9.1010601@laposte.net> <5673E3FD.8080001@laposte.net> Cc: Greg Kroah-Hartman , =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= , linux-serial@vger.kernel.org, LKML , Mason , Jon Anders Haugum From: Peter Hurley Message-ID: <56742F23.5010501@hurleysoftware.com> Date: Fri, 18 Dec 2015 08:06:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5673E3FD.8080001@laposte.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2154 Lines: 72 Hi Sebastian, On 12/18/2015 02:46 AM, Sebastian Frias wrote: > --- > > Some UART HW has a single register combining UART_DLL/UART_DLM > (this was probably forgotten in the change that introduced the > callbacks, commit b32b19b8ffc05cbd3bf91c65e205f6a912ca15d9) Thanks for the fix. Because of the heavy patchload here, it helps if the patches are don't need hand-editing by maintainers. Please drop the '---' separator and newline from the beginning of the commit log. Regards, Peter Hurley > Fixes: b32b19b8ffc0 Fixes: b32b19b8ffc0 ("[SERIAL] 8250: set divisor register correctly ...") > > Signed-off-by: Sebastian Frias > --- > drivers/tty/serial/8250/8250_port.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c > index 52d82d2..827eb6f 100644 > --- a/drivers/tty/serial/8250/8250_port.c > +++ b/drivers/tty/serial/8250/8250_port.c > @@ -713,22 +713,17 @@ static int size_fifo(struct uart_8250_port *up) > */ > static unsigned int autoconfig_read_divisor_id(struct uart_8250_port *p) > { > - unsigned char old_dll, old_dlm, old_lcr; > + unsigned char old_lcr; > unsigned int id; > + unsigned int old_dl; unsigned int id, old_dl; > > old_lcr = serial_in(p, UART_LCR); > serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A); > + old_dl = serial_dl_read(p); > + serial_dl_write(p, 0); > + id = serial_dl_read(p); > + serial_dl_write(p, old_dl); > > - old_dll = serial_in(p, UART_DLL); > - old_dlm = serial_in(p, UART_DLM); > - > - serial_out(p, UART_DLL, 0); > - serial_out(p, UART_DLM, 0); > - > - id = serial_in(p, UART_DLL) | serial_in(p, UART_DLM) << 8; > - > - serial_out(p, UART_DLL, old_dll); > - serial_out(p, UART_DLM, old_dlm); > serial_out(p, UART_LCR, old_lcr); > > return id; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/