Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932804AbbLRQTQ (ORCPT ); Fri, 18 Dec 2015 11:19:16 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:48736 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932640AbbLRQTO (ORCPT ); Fri, 18 Dec 2015 11:19:14 -0500 Date: Fri, 18 Dec 2015 11:19:03 -0500 From: Johannes Weiner To: Zefan Li Cc: Tejun Heo , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2] cgroup: clean up the kernel configuration menu nomenclature Message-ID: <20151218161903.GB4201@cmpxchg.org> References: <1450390797-4748-1-git-send-email-hannes@cmpxchg.org> <1450390797-4748-2-git-send-email-hannes@cmpxchg.org> <56736E07.4000300@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56736E07.4000300@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 36 On Fri, Dec 18, 2015 at 10:23:03AM +0800, Zefan Li wrote: > On 2015/12/18 6:19, Johannes Weiner wrote: > >The config options for the different cgroup controllers use various > >terms: resource controller, cgroup subsystem, etc. Simplify this to > >"controller", which is clear enough in the cgroup context. > > > >Signed-off-by: Johannes Weiner > >--- > > init/Kconfig | 65 ++++++++++++++++++++++++------------------------------------ > > 1 file changed, 26 insertions(+), 39 deletions(-) > > > >diff --git a/init/Kconfig b/init/Kconfig > >index 16840b4..ed324f5 100644 > >--- a/init/Kconfig > >+++ b/init/Kconfig > >@@ -958,23 +958,22 @@ menuconfig CGROUPS > > if CGROUPS > > > > config CGROUP_DEBUG > >- bool "Example debug cgroup subsystem" > >+ bool "Example controller" > > But not all cgroup subsystems are controllers, which are debug, perf and > cpuacct. I'm fine the other changes. Hm, I basically use the term controller to denote any modular component of cgroup that is not part of the cgroup core. Do we need to be more specific/accurate than that? Especially because there won't be any purely informational modules in cgroup2 anymore, they'll all actually control some resource or behavior. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/