Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933096AbbLRQmS (ORCPT ); Fri, 18 Dec 2015 11:42:18 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:48770 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294AbbLRQmQ (ORCPT ); Fri, 18 Dec 2015 11:42:16 -0500 Date: Fri, 18 Dec 2015 11:42:09 -0500 From: Johannes Weiner To: Arnd Bergmann Cc: Andrew Morton , Michal Hocko , Vladimir Davydov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] memcg: fix SLOB build regression Message-ID: <20151218164209.GD4201@cmpxchg.org> References: <13705081.IYJlPWfILN@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13705081.IYJlPWfILN@wuerfel> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1111 Lines: 24 On Fri, Dec 18, 2015 at 03:35:06PM +0100, Arnd Bergmann wrote: > A recent cleanup broke the build when CONFIG_SLOB is used: > > mm/memcontrol.c: In function 'memcg_update_kmem_limit': > mm/memcontrol.c:2974:9: error: implicit declaration of function 'memcg_online_kmem' [-Werror=implicit-function-declaration] > mm/memcontrol.c: In function 'mem_cgroup_css_alloc': > mm/memcontrol.c:4229:10: error: too many arguments to function 'memcg_propagate_kmem' > mm/memcontrol.c:2949:12: note: declared here > > This fixes the memcg_propagate_kmem prototype to match the normal > implementation and adds the respective memcg_online_kmem helper > function that was needed. > > Signed-off-by: Arnd Bergmann > Fixes: a5ed904c5039 ("mm: memcontrol: clean up alloc, online, offline, free functions") I am slob. Acked-by: Johannes Weiner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/