Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964954AbbLRRKD (ORCPT ); Fri, 18 Dec 2015 12:10:03 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:34760 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933007AbbLRRKA (ORCPT ); Fri, 18 Dec 2015 12:10:00 -0500 From: Minfei Huang To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, mhuang@redhat.com, Minfei Huang Subject: [PATCH] bio: Make the test correct for idx in __bio_clone_fast Date: Sat, 19 Dec 2015 01:09:57 +0800 Message-Id: <1450458597-20188-1-git-send-email-mnfhuang@gmail.com> X-Mailer: git-send-email 2.6.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 35 It is more lucky that kernel crash does not happen, since we test the bi_pool in function __bio_clone_fast. The idx will be still equal to BIO_POOL_NONE, if there is no bvec to be allocated. Fix the bug_on condition to make the test correct. Signed-off-by: Minfei Huang --- block/bio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/bio.c b/block/bio.c index 4f184d9..041ece0 100644 --- a/block/bio.c +++ b/block/bio.c @@ -573,8 +573,7 @@ EXPORT_SYMBOL(bio_phys_segments); */ void __bio_clone_fast(struct bio *bio, struct bio *bio_src) { - BUG_ON(bio->bi_pool && BIO_POOL_IDX(bio) != BIO_POOL_NONE); - + BUG_ON(BIO_POOL_IDX(bio) != BIO_POOL_NONE); /* * most users will be overriding ->bi_bdev with a new target, * so we don't set nor calculate new physical/hw segment counts here -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/