MIME-Version: 1.0
In-Reply-To: <56746774.8000707@linux.intel.com>
References: <CALCETrVw2V+Ny7=D=_E2m0Qa_v7Bp8GUjhyDXx_bWC35R2ohjg@mail.gmail.com>
	<56736BD1.5080700@linux.intel.com>
	<CALCETrWBjvTiVBPc098cGSH2vdezvdg-i6N4kZjgdcPT7uXoiQ@mail.gmail.com>
	<5673750B.606@linux.intel.com>
	<CALCETrWMofAX8TbZNyPaCWUHqcE85wpehDR05irEPtTYiVMXRA@mail.gmail.com>
	<FEA53E3B-6AE2-4305-82B1-C57451B6E33E@zytor.com>
	<CALCETrU28FoOwR+n8U0Qtt20=ZW6rgc3=M8X4G0QMt1_ZVHY7Q@mail.gmail.com>
	<567453AF.5060808@linux.intel.com>
	<CALCETrU7TnbLSzOuGNmh=xDpa5W729RJSPdap2izXxagfg-biQ@mail.gmail.com>
	<56746774.8000707@linux.intel.com>
Date: Fri, 18 Dec 2015 12:37:23 -0800
Message-ID: <CA+55aFycMWxCVY1p8n_D8nGz7Ky35uAmZMWm=zE5LBsqModiBg@mail.gmail.com>
Subject: Re: Rethinking sigcontext's xfeatures slightly for PKRU's benefit?
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Andy Lutomirski <luto@amacapital.net>, "H. Peter Anvin" <hpa@zytor.com>,
        Oleg Nesterov <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Brian Gerst <brgerst@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1018
Lines: 24

On Fri, Dec 18, 2015 at 12:07 PM, Dave Hansen
<dave.hansen@linux.intel.com> wrote:
>
> But, I think it's a small one.  Basically, RSP would have to pointing at
> a place which was allowed by protection keys for all of the sigframe
> setup.

Note that the whole "stack is special" is not at all a new issue.

It's the main reason why sigaltstack() and SS_ONSTACK exists. This is
in no way new to PKRU, people have had to handle the issue of
stack-related SIGSEGV faults for a long time.

So any application that uses PKRU and may play games that affects the
stack, will always have to have a separate "safe stack" that it uses
for signal handling. But that is in no way PKRU-specific, it's been
the case for a lot of other memory management faults.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/