Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965914AbbLRVlp (ORCPT ); Fri, 18 Dec 2015 16:41:45 -0500 Received: from down.free-electrons.com ([37.187.137.238]:38335 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965197AbbLRVll (ORCPT ); Fri, 18 Dec 2015 16:41:41 -0500 Date: Fri, 18 Dec 2015 22:41:12 +0100 From: Maxime Ripard To: Vishnu Patekar Cc: robh+dt@kernel.org, corbet@lwn.net, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, emilio@elopez.com.ar, linus.walleij@linaro.org, jenskuske@gmail.com, hdegoede@redhat.com, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-gpio@vger.kernel.org Subject: Re: [PATCH v3 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Message-ID: <20151218214112.GU30359@lukather> References: <1450445451-311-1-git-send-email-vishnupatekar0510@gmail.com> <1450445451-311-3-git-send-email-vishnupatekar0510@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/Rh48Y0bnrojh5Wm" Content-Disposition: inline In-Reply-To: <1450445451-311-3-git-send-email-vishnupatekar0510@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 8560 Lines: 287 --/Rh48Y0bnrojh5Wm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Dec 18, 2015 at 09:30:50PM +0800, Vishnu Patekar wrote: > Allwinner A83T is new octa-core cortex-a7 SOC. > This adds the basic dtsi, the clocks differs from > earlier sun8i SOCs. >=20 > Signed-off-by: Vishnu Patekar > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 206 ++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 206 insertions(+) > create mode 100644 arch/arm/boot/dts/sun8i-a83t.dtsi >=20 > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-= a83t.dtsi > new file mode 100644 > index 0000000..e577c64 > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -0,0 +1,206 @@ > +/* > + * Copyright 2015 Vishnu Patekar > + * > + * Vishnu Patekar > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + > + */ > + > +#include "skeleton.dtsi" > + > +#include > + > +#include > + > +/ { > + interrupt-parent =3D <&gic>; > + > + chosen { > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + ranges; > + }; > + > + cpus { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + cpu@0 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <0>; > + }; > + > + cpu@1 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <1>; > + }; > + > + cpu@2 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <2>; > + }; > + > + cpu@3 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <3>; > + }; A \n here please > + cpu@100 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <0x100>; > + }; > + > + cpu@101 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <0x101>; > + }; Ditto. > + cpu@102 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <0x102>; > + }; > + > + cpu@103 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <0x103>; > + }; > + }; > + > + memory { > + reg =3D <0x40000000 0x80000000>; > + }; Is mainline u-boot usable ? If so, you can remove that node entirely. > + > + timer { > + compatible =3D "arm,armv7-timer"; > + interrupts =3D , > + , > + , > + ; > + }; > + > + clocks { > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + ranges; > + > + osc24M: osc24M_clk { > + #clock-cells =3D <0>; > + compatible =3D "fixed-clock"; > + clock-frequency =3D <24000000>; > + clock-output-names =3D "osc24M"; > + }; > + > + osc32k: osc32k_clk { > + #clock-cells =3D <0>; > + compatible =3D "fixed-clock"; > + clock-frequency =3D <32768>; > + clock-output-names =3D "osc32k"; > + }; Do you need to modify the clocks driver in your first commit then? > + }; > + > + soc { > + compatible =3D "simple-bus"; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + ranges; > + > + gic: interrupt-controller@01c81000 { > + compatible =3D "arm,cortex-a7-gic", "arm,cortex-a15-gic"; > + reg =3D <0x01c81000 0x1000>, > + <0x01c82000 0x1000>, > + <0x01c84000 0x2000>, > + <0x01c86000 0x2000>; Please order the nodes by ascending physical addresses. > + interrupt-controller; > + #interrupt-cells =3D <3>; > + interrupts =3D ; > + }; > + > + pio: pinctrl@01c20800 { > + compatible =3D "allwinner,sun8i-a83t-pinctrl"; > + interrupts =3D , > + , > + ; > + reg =3D <0x01c20800 0x400>; > + clocks =3D <&osc24M>; > + gpio-controller; > + interrupt-controller; > + #interrupt-cells =3D <3>; > + #gpio-cells =3D <3>; > + > + mmc0_pins_a: mmc0@0 { > + allwinner,pins =3D "PF0", "PF1", "PF2", > + "PF3", "PF4", "PF5"; > + allwinner,function =3D "mmc0"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + uart0_pins_a: uart0@0 { > + allwinner,pins =3D "PF2", "PF4"; > + allwinner,function =3D "uart0"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + uart0_pins_b: uart0@1 { > + allwinner,pins =3D "PB9", "PB10"; > + allwinner,function =3D "uart0"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + }; > + > + uart0: serial@01c28000 { > + compatible =3D "snps,dw-apb-uart"; > + reg =3D <0x01c28000 0x400>; > + interrupts =3D ; > + reg-shift =3D <2>; > + reg-io-width =3D <4>; > + clocks =3D <&osc24M>; > + status =3D "disabled"; > + }; > + }; > +}; Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --/Rh48Y0bnrojh5Wm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWdH14AAoJEBx+YmzsjxAgh+YP/2Dap9JSDJEdFxyAGMvmtDag BhgWZUZZiAWcJpfHL0sdFR6lvdi0QaMnRnOcBDQR6sfdiQ/GJaYy59/yLZQivf4B nmWYeDSo6BabcXJXAdqClQ7bcg9yPToHRMjf5pGLt9B9CjVwue8Y+jaeW7AxSurO HcgEPT8A3rOTNSoj5MTZTdKI/cspdcIKlKLrKPWDIDQt4vP2rVkVCYXfoqM0rvn+ K/qVkilu+494LPxgvJu0ZDnuUxYQWs1sEc94cTRM/bTFC5luyT/PuByuXqz1BkN8 H+3eO3rByAd4tpXC8Ku00iytUXpvIWppQIJe+USf7KuZINpeCs9g9fUjd40mX6/X f/K/fisYMtKJ+6QWT+gIcacSfYWSpo4f9721DjaeSE//pvGZyotbW8t8AHqoXNOj 8bITKt1ZwMN1uM5hPh3s9rRPggmmwAPqe6cuS7V0gNfx6LtGAX+hTtpBfD1qhr0I TUAdU4IT1VEz8iHfCe21Gu2WVsYZuEm+ernfzxgLaFAXBmIuLJscExIMxtc5TKzy qzVZ1H9caIJQpUBvRuRSCoz2ZVUtshJIrSmJHXCaxwZjwW+RUU97xKZF/D6vksie B9dmliNNJqTmZdoQpAZ4ewGwOQ+V6hKO4NK2UnNolt0vyn74uortFuHNO4DXW7Fg PFJxECgVKV1Dy91MgJTA =G1bW -----END PGP SIGNATURE----- --/Rh48Y0bnrojh5Wm-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/