Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965416AbbLRVve (ORCPT ); Fri, 18 Dec 2015 16:51:34 -0500 Received: from mail-lf0-f44.google.com ([209.85.215.44]:35852 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965216AbbLRVvb (ORCPT ); Fri, 18 Dec 2015 16:51:31 -0500 Subject: Re: [PATCH 1/3] ARM: dts: bcm5301x: Add TWD WD Support to DT To: Jon Mason , Florian Fainelli References: <1450474676-10210-1-git-send-email-jonmason@broadcom.com> Cc: Hauke Mehrtens , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56747FDE.9040308@cogentembedded.com> Date: Sat, 19 Dec 2015 00:51:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1450474676-10210-1-git-send-email-jonmason@broadcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1450 Lines: 47 Hello. On 12/19/2015 12:37 AM, Jon Mason wrote: > Add support for the ARM TWD Watchdog to the bcm5301x device tree. The > ARM TWD timer allocated the register space for the WDT, so this patch > necessitated shrinking that. Also, the GIC masks were added for these. > > Signed-off-by: Jon Mason > --- > arch/arm/boot/dts/bcm5301x.dtsi | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi > index 65a1309..c31fafe 100644 > --- a/arch/arm/boot/dts/bcm5301x.dtsi > +++ b/arch/arm/boot/dts/bcm5301x.dtsi > @@ -66,10 +66,19 @@ > clocks = <&periph_clk>; > }; > > - local-timer@20600 { > + twd-timer@20600 { Please just "timer". The node names should be very generic, according to the ePAPR standard. > compatible = "arm,cortex-a9-twd-timer"; > - reg = <0x20600 0x100>; > - interrupts = ; > + reg = <0x20600 0x20>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + clocks = <&periph_clk>; > + }; > + > + twd-watchdog@20620 { Please, just "watchdog". MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/