Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965144AbbLRWIy (ORCPT ); Fri, 18 Dec 2015 17:08:54 -0500 Received: from mail-qk0-f176.google.com ([209.85.220.176]:34708 "EHLO mail-qk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998AbbLRWIx (ORCPT ); Fri, 18 Dec 2015 17:08:53 -0500 Date: Fri, 18 Dec 2015 17:08:49 -0500 From: "David Rivshin (Allworx)" To: Nicholas Mc Guire Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, Lars-Peter Clausen , Takashi Iwai , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ALSA: oss: consolidate kmalloc/memset 0 call to kzalloc Message-ID: <20151218170849.2a287c40.drivshin.allworx@gmail.com> In-Reply-To: <1450468917-32150-1-git-send-email-hofrat@osadl.org> References: <1450468917-32150-1-git-send-email-hofrat@osadl.org> Organization: Allworx X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 48 On Fri, 18 Dec 2015 21:01:57 +0100 Nicholas Mc Guire wrote: > This is an API consolidation only. The use of kmalloc + memset to 0 > is equivalent to kzalloc. > > Signed-off-by: Nicholas Mc Guire > --- > > Found by coccinelle script (relaxed version of > scripts/coccinelle/api/alloc/kzalloc-simple.cocci) > > Patch was compile tested with: x86_64_defconfig > CONFIG_SND_PCM_OSS=y > > Patch is against linux-next (localversion-next is -next-20150518) > > diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c > index e557dbe..8cdd06f 100644 > --- a/sound/core/oss/pcm_oss.c > +++ b/sound/core/oss/pcm_oss.c > @@ -850,7 +850,7 @@ static int snd_pcm_oss_change_params(struct > snd_pcm_substream *substream) > if (mutex_lock_interruptible(&runtime->oss.params_lock)) > return -EINTR; > - sw_params = kmalloc(sizeof(*sw_params), GFP_KERNEL); > + sw_params = kmalloc(sizeof(*sw_params), GFP_KERNEL); ^ Something odd (manual edit?) seems to have happened to this hunk, making it a no-op. I presume that 'm' was supposed to be a 'z'. > params = kmalloc(sizeof(*params), GFP_KERNEL); > sparams = kmalloc(sizeof(*sparams), GFP_KERNEL); > if (!sw_params || !params || !sparams) { > @@ -988,7 +988,6 @@ static int snd_pcm_oss_change_params(struct > snd_pcm_substream *substream) goto failure; > } > > - memset(sw_params, 0, sizeof(*sw_params)); > if (runtime->oss.trigger) { > sw_params->start_threshold = 1; > } else { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/