Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbbLRWzN (ORCPT ); Fri, 18 Dec 2015 17:55:13 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36377 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbbLRWzL (ORCPT ); Fri, 18 Dec 2015 17:55:11 -0500 Date: Fri, 18 Dec 2015 14:55:08 -0800 From: Brian Norris To: Yao Yuan Cc: "dwmw2@infradead.org" , Xu Han , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support Message-ID: <20151218225508.GT10460@google.com> References: <1447838008-3744-1-git-send-email-yao.yuan@freescale.com> <20151125190900.GA2959@chopperman.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 31 On Fri, Dec 18, 2015 at 09:12:13AM +0000, Yao Yuan wrote: > Hi Woodhouse, Norris, > > Do you have any comments for this patch? No, it looks fine. But the driver maintainer (Han) already asked you for DT binding documentation already. This is a requirement before I can merge your patch. See Documentation/devicetree/bindings/submitting-patches.txt. > Thanks for your review. > > Best Regards, > Yuan Yao > > > -----Original Message----- > > From: Han Xu [mailto:han.xu@freescale.com] > > > + q->big_endian = of_property_read_bool(np, "big-endian"); > > > > I am fine with this patch, but need document the new property with another > > patch ^^^ See here Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/