Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932212AbbLRXDY (ORCPT ); Fri, 18 Dec 2015 18:03:24 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43148 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbbLRXDW (ORCPT ); Fri, 18 Dec 2015 18:03:22 -0500 Date: Fri, 18 Dec 2015 15:03:20 -0800 From: Andrew Morton To: Peter Zijlstra Cc: Daniel Thompson , Jiri Kosina , Russell King - ARM Linux , Petr Mladek , Geert Uytterhoeven , Steven Rostedt , Ingo Molnar , Thomas Gleixner , "linux-kernel@vger.kernel.org" , the arch/x86 maintainers , "linux-arm-kernel@lists.infradead.org" , "adi-buildroot-devel@lists.sourceforge.net" , Cris , Linux MIPS Mailing List , "linuxppc-dev@lists.ozlabs.org" , linux-s390 , Linux-sh list , sparclinux Subject: Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Message-Id: <20151218150320.5d377789ee6253379b82412d@linux-foundation.org> In-Reply-To: <20151218121141.GR6373@twins.programming.kicks-ass.net> References: <1449667265-17525-1-git-send-email-pmladek@suse.com> <1449667265-17525-5-git-send-email-pmladek@suse.com> <20151211124159.GB3729@pathway.suse.cz> <20151211145725.b0e81bb4bb18fcd72ef5f557@linux-foundation.org> <20151211232113.GZ8644@n2100.arm.linux.org.uk> <5673DD60.7080302@linaro.org> <20151218112902.GO6344@twins.programming.kicks-ass.net> <20151218121141.GR6373@twins.programming.kicks-ass.net> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 30 On Fri, 18 Dec 2015 13:11:41 +0100 Peter Zijlstra wrote: > On Fri, Dec 18, 2015 at 12:29:02PM +0100, Peter Zijlstra wrote: > > On Fri, Dec 18, 2015 at 10:18:08AM +0000, Daniel Thompson wrote: > > > I'm not entirely sure that this is an improvement. > > > > What I do these days is delete everything in vprintk_emit() and simply > > call early_printk(). > > On that, whoever made the device model use vprintk_emit() broke the > debugger (KGDB/KDB) printk intercept, and the whole vprintk_func > redirection scheme. crap, we have a whole set of interfaces which are broken this way. printk_emit(), vprintk(), vprintk_emit(). commit 7ff9554bb578ba02166071d2d487b7fc7d860d62 Author: Kay Sievers AuthorDate: Thu May 3 02:29:13 2012 +0200 Commit: Greg Kroah-Hartman CommitDate: Mon May 7 16:53:02 2012 -0700 printk: convert byte-buffer to variable-length record buffer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/