Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932506AbbLSAst (ORCPT ); Fri, 18 Dec 2015 19:48:49 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35347 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbbLSAss (ORCPT ); Fri, 18 Dec 2015 19:48:48 -0500 Date: Fri, 18 Dec 2015 16:48:45 -0800 From: Brian Norris To: Ezequiel Garcia Cc: Robert Jarzmik , Ezequiel Garcia , David Woodhouse , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Message-ID: <20151219004845.GW10460@google.com> References: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> <20150818042426.GA27858@laptop> <874mjwa1w6.fsf@belgarion.home> <87r3mt3jpw.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1464 Lines: 34 Garbage collecting some old patches before vacation... On Mon, Aug 24, 2015 at 10:46:18AM -0300, Ezequiel Garcia wrote: > I agree that the hack is useful for debugging purposes, it's just that I don't > see why we want it in mainline - where we usually avoid clutter. I'm not sure this is really that important of clutter. It's in a nicely hidden abstraction (the local nand_{read,write}l() helpers), and it doesn't add any compile time cost for most users. > Also, your argument applies to all the other drivers, but that doesn't mean > we will patch them all. > > Anyway, this is just my opinion. If Brian thinks differently, I have no problem > with it. I don't have very strong opinions on this. It's kind of annoying to have this sort of stuff duplicated for every driver, if it's really needed. But I'll admit this kind of infrastructure is sometimes useful. Anecdote: I recently found the regmap trace event infrastructure pretty nice for debugging some other drivers. This would only require you to have tracing enabled, and then no recompiles are necessary at all. Just cmdline changes. So, I could go with this patch, if Robert still desires it. Or you could convert to using regmap for MMIO :) Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/