Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182AbbLSFuI (ORCPT ); Sat, 19 Dec 2015 00:50:08 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:34142 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbbLSFuH (ORCPT ); Sat, 19 Dec 2015 00:50:07 -0500 MIME-Version: 1.0 In-Reply-To: <5674C068.9000809@infradead.org> References: <5674C068.9000809@infradead.org> Date: Sat, 19 Dec 2015 13:50:05 +0800 Message-ID: Subject: Re: Indent issus in kernel module development From: chunguang qu To: Randy Dunlap , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1754 Lines: 59 Yes, I just tried `scripts/Lindent` and it has the same problem. I had compared the source of `Lindent` with `-linux` option of `indent` long time ago, there's seems no major difference. So i used `indent -linux ` above. Thanks for your advice about `emace`, but `vi` is my only editor for dozens of years. 2015-12-19 10:26 GMT+08:00 Randy Dunlap : > On 12/18/15 18:07, chunguang qu wrote: >> `indent -linux` sometimes made my code totally a mess. >> I know it most likely a bug of GNU INDENT. And this is not a bug report. >> I only want to know other kernel developers how to deal with this problem. >> Since GUN INDENT is recommend in kernel's CodingStyle, I think surely >> someone here encounter this problem either. > > Huh? > > CodingStyle says: > > Now, again, GNU indent has the same brain-dead settings that GNU emacs > has, which is why you need to give it a few command line options. > > It also says try using scripts/Lindent. Have you tried it? > It won't be perfect either, AFAI recall, but it might help. > > or you could try emacs (as indicated in CodingStyle). Good luck with that. > > > >> CMD >> LANG=C indent -linux >> >> FROM >> http://paste.ubuntu.com/14093393/ >> >> TO >> http://paste.ubuntu.com/14093405/ >> >> Thanks. > > > > > -- > ~Randy -- [Kevin Q (ChunGuang Qu)](mailto:quchunguang@gmail.com) [public key](http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x5B06DCA77BEF043B) @sdu.edu.cn @gnu.org @mit.edu @grazestar.com @jolijolie.cn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/