Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067AbbLSK5T (ORCPT ); Sat, 19 Dec 2015 05:57:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40663 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbbLSK5Q (ORCPT ); Sat, 19 Dec 2015 05:57:16 -0500 Subject: Re: [linux-sunxi] Re: [PATCH v3 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi To: Maxime Ripard , Vishnu Patekar References: <1450445451-311-1-git-send-email-vishnupatekar0510@gmail.com> <1450445451-311-3-git-send-email-vishnupatekar0510@gmail.com> <20151218214112.GU30359@lukather> Cc: robh+dt@kernel.org, corbet@lwn.net, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, emilio@elopez.com.ar, linus.walleij@linaro.org, jenskuske@gmail.com, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-gpio@vger.kernel.org From: Hans de Goede Message-ID: <567537FF.9010601@redhat.com> Date: Sat, 19 Dec 2015 11:57:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151218214112.GU30359@lukather> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7600 Lines: 262 Hi, On 18-12-15 22:41, Maxime Ripard wrote: > Hi, > > On Fri, Dec 18, 2015 at 09:30:50PM +0800, Vishnu Patekar wrote: >> Allwinner A83T is new octa-core cortex-a7 SOC. >> This adds the basic dtsi, the clocks differs from >> earlier sun8i SOCs. >> >> Signed-off-by: Vishnu Patekar >> --- >> arch/arm/boot/dts/sun8i-a83t.dtsi | 206 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 206 insertions(+) >> create mode 100644 arch/arm/boot/dts/sun8i-a83t.dtsi >> >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >> new file mode 100644 >> index 0000000..e577c64 >> --- /dev/null >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >> @@ -0,0 +1,206 @@ >> +/* >> + * Copyright 2015 Vishnu Patekar >> + * >> + * Vishnu Patekar >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + >> + */ >> + >> +#include "skeleton.dtsi" >> + >> +#include >> + >> +#include >> + >> +/ { >> + interrupt-parent = <&gic>; >> + >> + chosen { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + }; >> + >> + cpus { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + cpu@0 { >> + compatible = "arm,cortex-a7"; >> + device_type = "cpu"; >> + reg = <0>; >> + }; >> + >> + cpu@1 { >> + compatible = "arm,cortex-a7"; >> + device_type = "cpu"; >> + reg = <1>; >> + }; >> + >> + cpu@2 { >> + compatible = "arm,cortex-a7"; >> + device_type = "cpu"; >> + reg = <2>; >> + }; >> + >> + cpu@3 { >> + compatible = "arm,cortex-a7"; >> + device_type = "cpu"; >> + reg = <3>; >> + }; > > A \n here please > >> + cpu@100 { >> + compatible = "arm,cortex-a7"; >> + device_type = "cpu"; >> + reg = <0x100>; >> + }; >> + >> + cpu@101 { >> + compatible = "arm,cortex-a7"; >> + device_type = "cpu"; >> + reg = <0x101>; >> + }; > > Ditto. > >> + cpu@102 { >> + compatible = "arm,cortex-a7"; >> + device_type = "cpu"; >> + reg = <0x102>; >> + }; >> + >> + cpu@103 { >> + compatible = "arm,cortex-a7"; >> + device_type = "cpu"; >> + reg = <0x103>; >> + }; >> + }; >> + >> + memory { >> + reg = <0x40000000 0x80000000>; >> + }; > > Is mainline u-boot usable ? If so, you can remove that node entirely. mainline u-boot works for me when cold-booting from a sdcard, so I consider it usable :) Regards, Hans > >> + >> + timer { >> + compatible = "arm,armv7-timer"; >> + interrupts = , >> + , >> + , >> + ; >> + }; >> + >> + clocks { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + osc24M: osc24M_clk { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <24000000>; >> + clock-output-names = "osc24M"; >> + }; >> + >> + osc32k: osc32k_clk { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <32768>; >> + clock-output-names = "osc32k"; >> + }; > > Do you need to modify the clocks driver in your first commit then? > >> + }; >> + >> + soc { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + gic: interrupt-controller@01c81000 { >> + compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; >> + reg = <0x01c81000 0x1000>, >> + <0x01c82000 0x1000>, >> + <0x01c84000 0x2000>, >> + <0x01c86000 0x2000>; > > Please order the nodes by ascending physical addresses. > >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + interrupts = ; >> + }; >> + >> + pio: pinctrl@01c20800 { >> + compatible = "allwinner,sun8i-a83t-pinctrl"; >> + interrupts = , >> + , >> + ; >> + reg = <0x01c20800 0x400>; >> + clocks = <&osc24M>; >> + gpio-controller; >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + #gpio-cells = <3>; >> + >> + mmc0_pins_a: mmc0@0 { >> + allwinner,pins = "PF0", "PF1", "PF2", >> + "PF3", "PF4", "PF5"; >> + allwinner,function = "mmc0"; >> + allwinner,drive = ; >> + allwinner,pull = ; >> + }; >> + >> + uart0_pins_a: uart0@0 { >> + allwinner,pins = "PF2", "PF4"; >> + allwinner,function = "uart0"; >> + allwinner,drive = ; >> + allwinner,pull = ; >> + }; >> + >> + uart0_pins_b: uart0@1 { >> + allwinner,pins = "PB9", "PB10"; >> + allwinner,function = "uart0"; >> + allwinner,drive = ; >> + allwinner,pull = ; >> + }; >> + }; >> + >> + uart0: serial@01c28000 { >> + compatible = "snps,dw-apb-uart"; >> + reg = <0x01c28000 0x400>; >> + interrupts = ; >> + reg-shift = <2>; >> + reg-io-width = <4>; >> + clocks = <&osc24M>; >> + status = "disabled"; >> + }; >> + }; >> +}; > > Thanks! > Maxime > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/