Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933159AbbLSMTa (ORCPT ); Sat, 19 Dec 2015 07:19:30 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:60187 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932748AbbLSMT3 (ORCPT ); Sat, 19 Dec 2015 07:19:29 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 19 Dec 2015 13:19:28 +0100 X-ME-IP: 109.222.211.19 From: Robert Jarzmik To: Brian Norris Cc: Ezequiel Garcia , Ezequiel Garcia , David Woodhouse , "linux-mtd\@lists.infradead.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug References: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> <20150818042426.GA27858@laptop> <874mjwa1w6.fsf@belgarion.home> <87r3mt3jpw.fsf@belgarion.home> <20151219004845.GW10460@google.com> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 19 Dec 2015 13:19:26 +0100 In-Reply-To: <20151219004845.GW10460@google.com> (Brian Norris's message of "Fri, 18 Dec 2015 16:48:45 -0800") Message-ID: <87lh8qhbqp.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1104 Lines: 28 Brian Norris writes: > I don't have very strong opinions on this. It's kind of annoying to have > this sort of stuff duplicated for every driver, if it's really needed. > But I'll admit this kind of infrastructure is sometimes useful. > > Anecdote: I recently found the regmap trace event infrastructure pretty > nice for debugging some other drivers. This would only require you to > have tracing enabled, and then no recompiles are necessary at all. Just > cmdline changes. > > So, I could go with this patch, if Robert still desires it. Or you could > convert to using regmap for MMIO :) I'm as you, I don't feel strong opinion about it, I'd like to have a debug tracing tool, be that this patch or regmap MMIO. If we all agree on a path I could even make the final patch, whichever solution is chosen. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/