Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933283AbbLSPFw (ORCPT ); Sat, 19 Dec 2015 10:05:52 -0500 Received: from www.linutronix.de ([62.245.132.108]:43439 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932302AbbLSPFv (ORCPT ); Sat, 19 Dec 2015 10:05:51 -0500 Date: Sat, 19 Dec 2015 16:05:00 +0100 (CET) From: Thomas Gleixner To: Jeff Merkey cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, peterz@infradead.org, luto@kernel.org Subject: Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints In-Reply-To: <20151215061250.GA7233@localhost.localdomain> Message-ID: References: <20151215061250.GA7233@localhost.localdomain> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 23 On Mon, 14 Dec 2015, Jeff Merkey wrote: > + /* > + * check if we got an execute breakpoint > + * from the dr7 register. if we did, set > + * the resume flag to avoid int1 recursion. Malformatted comment as any other comment you touched. > + */ > + if ((dr7 & (3 << ((i * 4) + 16))) == 0) > + args->regs->flags |= X86_EFLAGS_RF; This still uses magic numbers instead of the proper defines. I asked for that before. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/