Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933295AbbLSPHG (ORCPT ); Sat, 19 Dec 2015 10:07:06 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:55705 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932302AbbLSPHE (ORCPT ); Sat, 19 Dec 2015 10:07:04 -0500 Subject: Re: [PATCH] iio: ina2xx: fix channel order in software buffer To: Marc Titinger , knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net References: <566C5613.3040101@kernel.org> <1450193182-18179-1-git-send-email-mtitinger@baylibre.com> Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <56757296.5060501@kernel.org> Date: Sat, 19 Dec 2015 15:07:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450193182-18179-1-git-send-email-mtitinger@baylibre.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1509 Lines: 46 On 15/12/15 15:26, Marc Titinger wrote: > POWER and CURRENT were swapped out in the buffer: > was current2 and power3, correct order is power2 and current3. > > Signed-off-by: Marc Titinger > > --- > > Hi Jon, > > we just found this while testing with the buffered mode. > My apologies for missing this bug ealier. > > Cheers, > Marc. > > --- > Applied this one to the togreg branch of iio.git which will get initially pushed out as testing for the autobuilders to play with it. > drivers/iio/adc/ina2xx-adc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c > index 98939ba..91e1f2b 100644 > --- a/drivers/iio/adc/ina2xx-adc.c > +++ b/drivers/iio/adc/ina2xx-adc.c > @@ -427,8 +427,8 @@ static ssize_t ina2xx_shunt_resistor_store(struct device *dev, > static const struct iio_chan_spec ina2xx_channels[] = { > INA2XX_CHAN_VOLTAGE(0, INA2XX_SHUNT_VOLTAGE), > INA2XX_CHAN_VOLTAGE(1, INA2XX_BUS_VOLTAGE), > - INA2XX_CHAN(IIO_CURRENT, 2, INA2XX_CURRENT), > - INA2XX_CHAN(IIO_POWER, 3, INA2XX_POWER), > + INA2XX_CHAN(IIO_POWER, 2, INA2XX_POWER), > + INA2XX_CHAN(IIO_CURRENT, 3, INA2XX_CURRENT), > IIO_CHAN_SOFT_TIMESTAMP(4), > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/