Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932988AbbLSTbm (ORCPT ); Sat, 19 Dec 2015 14:31:42 -0500 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:29808 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932637AbbLSTbe (ORCPT ); Sat, 19 Dec 2015 14:31:34 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 19 Dec 2015 20:31:32 +0100 X-ME-IP: 109.222.211.19 From: Robert Jarzmik To: Sergei Ianovich Cc: linux-kernel@vger.kernel.org, Kevin Hilman , Arnd Bergmann , "moderated list\:ARM PORT" , "open list\:SERIAL DRIVERS" Subject: Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core References: <1387309071-22382-1-git-send-email-ynvich@gmail.com> <1449700088-28076-1-git-send-email-ynvich@gmail.com> <1449700088-28076-2-git-send-email-ynvich@gmail.com> <8737uyhaji.fsf@belgarion.home> <87y4cqfu2j.fsf@belgarion.home> <1450550792.15911.5.camel@gmail.com> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 19 Dec 2015 20:31:28 +0100 In-Reply-To: <1450550792.15911.5.camel@gmail.com> (Sergei Ianovich's message of "Sat, 19 Dec 2015 21:46:32 +0300") Message-ID: <87twnefd67.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2142 Lines: 54 Sergei Ianovich writes: > On Sat, 2015-12-19 at 14:26 +0100, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> >> > Sergei Ianovich writes: >> > >> > > pxa2xx-uart was a separate uart platform driver. It was declaring >> > > the same device names and numbers as 8250 driver. As a result, >> > > it was impossible to use 8250 driver on PXA SoCs. >> > > >> > > Upon closer examination pxa2xx-uart turned out to be a clone of >> > > 8250_core driver. >> > > >> > > Workaround for Erratum #19 according to Marvel(R) PXA270M >> > > Processor >> > > Specification Update (April 19, 2010) is dropped. 8250_core reads >> > > from FIFO immediately after checking DR bit in LSR. >> > > >> > > Signed-off-by: Sergei Ianovich >> > > Reviewed-by: Heikki Krogerus >> > > Reviewed-by: James Cameron >> > > Acked-by: Greg Kroah-Hartman >> > Tested-by: Robert Jarzmik >> >> Shrunk the list, the following is rather mach-pxa specific. >> >> Actually there is a small glitch ... >> Have a look at arch/arm/mach-pxa/viper.c, line 490: >> #ifndef CONFIG_SERIAL_PXA >> ... > > Thanks for spotting this. This is caused by a change in the latest > version of the patch (SERIAL_8250_PXA instead of SERIAL_PXA). This > change could be reverted. Actually I'm against the revert. The name change looks very good to me, please keep it. >> But that can be handled in an subsequent patch to keep your acks and >> reviews. > I will respin the patch. Please comment on the acks and reviews. They > were made at an earlier version of the patch. That version no longer > applies. Can the updated version carry on the flags? I don't get you. If you mean keeping CONFIG_SERIAL_8250_PXA, then yes, please keep it. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/