Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754092AbbLTCjL (ORCPT ); Sat, 19 Dec 2015 21:39:11 -0500 Received: from mail-io0-f176.google.com ([209.85.223.176]:35165 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbbLTCjJ (ORCPT ); Sat, 19 Dec 2015 21:39:09 -0500 MIME-Version: 1.0 In-Reply-To: References: <20151220021347.GA14466@localhost.localdomain> <1450578711.3793.8.camel@gmail.com> Date: Sat, 19 Dec 2015 19:39:08 -0700 Message-ID: Subject: Re: [PATCH v4] Fix INT1 Recursion with unregistered breakpoints From: Jeff Merkey To: Mike Galbraith Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, peterz@infradead.org, luto@kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 48 On 12/19/15, Jeff Merkey wrote: > On 12/19/15, Jeff Merkey wrote: >> On 12/19/15, Mike Galbraith wrote: >>> On Sat, 2015-12-19 at 19:13 -0700, Jeff Merkey wrote: >>> >>>> @@ -519,6 +528,18 @@ static int hw_breakpoint_handler(struct die_args >>>> *args) >>>> (dr6 & (~DR_TRAP_BITS))) >>>> rc = NOTIFY_DONE; >>>> >>>> + /* >>>> + * if we are about to signal to >>>> + * do_debug() to stop further processing >>>> + * and we have not ascertained the source >>>> + * of the breakpoint, log it as spurious. >>>> + */ >>> >>> Ahem... >>> >>> >>> >> >> It matches the comments in the other section os code. So what is >> wrong with this. The rest of the file uses the exact same comment >> style. >> >> Please help me with this. >> >> Jeff >> > > OK. Somethings fritzed with how my emails are getting sent. I just > create this, tested it, > and it applies PERFECTLY to my git clone. Let me go back and try again. > > Throw this one away. try try again. > > Jeff > I sent v4 and its appears to be right. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/