From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
To: Felipe Balbi <balbi@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
Thread-Topic: [PATCH 0/7][v4] Add OTG support for FSL socs
Thread-Index: AQHQ4OWrgOU2d//7ekyw3S1I97iTKp5j8FUAgAACWoCAA65gQA==
Date: Sun, 20 Dec 2015 04:52:53 +0000
Message-ID: <SN1PR0301MB1583726C9AD04F1E36CBB8EAE0E30@SN1PR0301MB1583.namprd03.prod.outlook.com>
References: <1440693787-7339-1-git-send-email-ramneek.mehresh@freescale.com>
 <87fv1ju42r.fsf@saruman.tx.rr.com> <87a8rru3oq.fsf@saruman.tx.rr.com>
In-Reply-To: <87a8rru3oq.fsf@saruman.tx.rr.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2015 04:52:53.8372
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1583
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2236
Lines: 52


> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@ti.com]
> Sent: Saturday, October 10, 2015 3:04 AM
> To: Mehresh Ramneek-B31383 <ramneek.mehresh@freescale.com>; linux-
> kernel@vger.kernel.org
> Cc: stern@rowland.harvard.edu; gregkh@linuxfoundation.org; linux-
> usb@vger.kernel.org; Mehresh Ramneek-B31383
> <ramneek.mehresh@freescale.com>
> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> Felipe Balbi <balbi@ti.com> writes:
> 
> > Hi,
> >
> > Ramneek Mehresh <ramneek.mehresh@freescale.com> writes:
> >> Add support for otg for all freescale socs having internal usb phy.
> >>
> >> Ramneek Mehresh (7):
> >>   usb:fsl:otg: Make fsl otg driver as tristate
> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> >>   usb:fsl:otg: Add support to add/remove usb host driver
> >>   usb:fsl:otg: Signal host drv when host is otg
> >>   usb:fsl:otg: Modify otg_event to start host drv
> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> >>   usb:fsl:otg: Add host-gadget drv sync delay
> >
> > Unless Alan's okay with the host side changes, I can't accept any of
> > these. However, I must say some of the flags you add here already
> > exist in some way, shape or form. For example, look at is_b_host flag.
> 
Could you please be more specific...which flag you think that I should remove/I'm
re-defining. The flags I'm defining are:
have_hcd : defined in fsl specific structure for fsl specific use-case
had_hcd: defined in fsl specific structure for fsl specific use-case
is_otg : defined in include/linux/usb.h
Are you suggesting using otg_port or is_b_host instead of is_otg?
As I understand, is_b_host is specifically to check if an otg B device is in host mode...correct?
I just need a flag to check if a controller is capable of otg operations? That's why defined
"is_otg" flag. Please suggest.

> Just saw Alan's reply, still, please have a look at these other flags which
> already exist in usbcore today.
> 
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/