Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669AbbLTFVo (ORCPT ); Sun, 20 Dec 2015 00:21:44 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:35427 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbbLTFVn (ORCPT ); Sun, 20 Dec 2015 00:21:43 -0500 Date: Sat, 19 Dec 2015 21:21:34 -0800 From: Darren Hart To: Thomas Gleixner Cc: Davidlohr Bueso , Bhuvanesh_Surachari@mentor.com, Peter Zijlstra , Ingo Molnar , Andrew Morton , linux@rasmusvillemoes.dk, viresh.kumar@linaro.org, luto@amacapital.net, Sebastian Sewior , mtk.manpages@gmail.com, LKML , Andy Lowe Subject: Re: [PATCH] futex: Prevent pi_state from double freeing in case of error Message-ID: <20151220052134.GI7244@malice.jf.intel.com> References: <1450428223-7655-1-git-send-email-Bhuvanesh_Surachari@mentor.com> <20151218145534.GD17386@linux-uzut.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 33 On Sat, Dec 19, 2015 at 07:24:38PM +0100, Thomas Gleixner wrote: > - Why are the reviews so sloppy and useless? > > The one I'm answering to is just hillarious and the other one picks > a random commit, claims that it inadvertantly introduced the issue > and is done with it. Really helpful. > > Folks, this is not the way it works. It took me a couple of hours to > get this analyzed properly, but I don't see that anyone involved in > this thread has spent more than a few seconds on it. > > At least I found a real issue related to this refcount stuff, but I > would have preferred that the people involved in this would have found > it in the first place instead of providing half baken crap. > > Yours grumpy > > tglx More care was clearly warranted on my part. I thought I saw the connection with the previous commit I referenced (it wasn't random!), but clearly didn't dig deep enough. My apologies, -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/