Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172AbbLTHu1 (ORCPT ); Sun, 20 Dec 2015 02:50:27 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34238 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbbLTHu0 (ORCPT ); Sun, 20 Dec 2015 02:50:26 -0500 Message-ID: <56765DB4.5070901@gmail.com> Date: Sun, 20 Dec 2015 15:50:12 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dmitry Torokhov CC: Caesar Wang , huangtao@rock-chips.com, Heiko Stuebner , linux-pm@vger.kernel.org, dianders@chromium.org, linux-kernel@vger.kernel.org, Eduardo Valentin , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Zhang Rui , computersforpeace@gmail.com, Dan Carpenter Subject: Re: [PATCH v3 2/5] thermal: rockchip: fix a impossible condition caused by the warning References: <1449132523-18817-1-git-send-email-wxt@rock-chips.com> <1449132523-18817-3-git-send-email-wxt@rock-chips.com> <20151203201908.GA34901@dtor-ws> In-Reply-To: <20151203201908.GA34901@dtor-ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2721 Lines: 83 在 2015年12月04日 04:19, Dmitry Torokhov 写道: > On Thu, Dec 03, 2015 at 04:48:40PM +0800, Caesar Wang wrote: >> As the Dan report the smatch check the thermal driver warning: >> drivers/thermal/rockchip_thermal.c:551 rockchip_configure_from_dt() >> warn: impossible condition '(thermal->tshut_temp > ((~0 >> 1))) => >> (s32min-s32max > s32max)' >> >> Let's we remove the imposssible condition Since the Temperature is >> currently represented as int not long in the thermal driver. >> >> Fixes: commit 437df2172e8d >> ("thermal: rockchip: consistently use int for temperatures") >> >> Reported-by: Dan Carpenter >> Signed-off-by: Caesar Wang >> >> --- >> >> Changes in v3: >> - As Brian comments on https://patchwork.kernel.org/patch/7580661/, >> let's remove the impossible condition. >> >> Changes in v2: None >> Changes in v1: None >> >> drivers/thermal/rockchip_thermal.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c >> index ae796ec..611de00 100644 >> --- a/drivers/thermal/rockchip_thermal.c >> +++ b/drivers/thermal/rockchip_thermal.c >> @@ -549,12 +549,6 @@ static int rockchip_configure_from_dt(struct device *dev, >> thermal->tshut_temp = shut_temp; >> } >> >> - if (thermal->tshut_temp > INT_MAX) { >> - dev_err(dev, "Invalid tshut temperature specified: %d\n", >> - thermal->tshut_temp); >> - return -ERANGE; >> - } > Well, that is not entirely correct. The value that we read from DT is > u32, but we convert it down to int. I believe you want to move the check > up so that you do: > > } else if (tshut_temp > INT_MAX) { > dev_err(dev, "Invalid tshut temperature specified: %d\n", > thermal->tshut_temp); > return -ERANGE; > } else { > thermal->tshut_temp = shut_temp; > } Okay, that's seem the following wll be resonable since the checkcode is a warning. if (of_property_read_u32(np, "rockchip,hw-tshut-temp", &shut_temp)) { dev_warn(dev, "Missing tshut temp property, using default %d\n", thermal->chip->tshut_temp); thermal->tshut_temp = thermal->chip->tshut_temp; } else { if (tshut_temp > INT_MAX) { dev_err(dev, "Invalid tshut temperature specified: %d\n", tshut_temp); return -ERANGE; } thermal->tshut_temp = shut_temp; } Thanks, > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/