Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932948AbbLTLYc (ORCPT ); Sun, 20 Dec 2015 06:24:32 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:33974 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932597AbbLTLY3 (ORCPT ); Sun, 20 Dec 2015 06:24:29 -0500 Message-ID: <1450610665.15911.53.camel@gmail.com> Subject: Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core From: Sergei Ianovich To: Robert Jarzmik , Kevin Hilman , Arnd Bergmann Cc: Greg Kroah-Hartman , Russell King - ARM Linux , linux-kernel@vger.kernel.org, "moderated list:ARM PORT" , "open list:SERIAL DRIVERS" Date: Sun, 20 Dec 2015 14:24:25 +0300 In-Reply-To: <87poy2f2xw.fsf@belgarion.home> References: <1387309071-22382-1-git-send-email-ynvich@gmail.com> <1449700088-28076-1-git-send-email-ynvich@gmail.com> <1449700088-28076-2-git-send-email-ynvich@gmail.com> <8737uyhaji.fsf@belgarion.home> <87y4cqfu2j.fsf@belgarion.home> <1450550792.15911.5.camel@gmail.com> <87twnefd67.fsf@belgarion.home> <1450555955.15911.14.camel@gmail.com> <87poy2f2xw.fsf@belgarion.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1986 Lines: 50 On Sun, 2015-12-20 at 00:12 +0100, Robert Jarzmik wrote: > Sergei Ianovich writes: > > > On Sat, 2015-12-19 at 20:31 +0100, Robert Jarzmik wrote: > > > Sergei Ianovich writes: > > > Thanks for spotting this. This is caused by a change in the latest > > > > version of the patch (SERIAL_8250_PXA instead of SERIAL_PXA). > > > > This > > > > change could be reverted. > > > Actually I'm against the revert. > > > The name change looks very good to me, please keep it. > > > > Is it worth adding an error if CONFIG_SERIAL_PXA is defined? > I don't think so. ... > > > I understand that people are afraid of taking this patch. If it > > starts > > causing troubles at runtime, it will be difficult to diagnose. There > > will be no console for most people. So it is probably good idea to > > fail > > at boot time. > Who are "the people" ? I think "the people" are at least Greg Kroah-Hartman and Russell King. > If it's about something already written in a mailing > list, please point me to it so that it can help me think about it. http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/2167 73.html I can explain why I think so. Greg acked the patch, but hasn't merged it since then. He has good reasons for this most probably. Russell's comment pointed by the link seems to be the reason. I think the problem raised by Russell could be addressed. My best guess is compile time error, despite your comment above. I have one more plan. For transition period, we can introduce a temporary Kconfig option SERIAL_8250_PXA_OFF, and fail at build time if neither SERIAL_8250_PXA nor SERIAL_8250_PXA_OFF is set. This way all interested parties will be notified of this driver update. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/