Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754373AbbLTMVA (ORCPT ); Sun, 20 Dec 2015 07:21:00 -0500 Received: from mail-ob0-f182.google.com ([209.85.214.182]:35418 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbbLTMU7 (ORCPT ); Sun, 20 Dec 2015 07:20:59 -0500 MIME-Version: 1.0 From: Andy Lutomirski Date: Sun, 20 Dec 2015 04:20:39 -0800 Message-ID: Subject: firmware_class warnings on resume To: Ming Lei , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 778 Lines: 26 I hit this warning fairly frequently when resuming 4.4-rc5: ret = usermodehelper_read_trylock(); if (WARN_ON(ret)) { dev_err(device, "firmware: %s will not be loaded\n", name); goto out; } It seems like it could be improved in two ways fairly easily: 1. Shouldn't firmware_class try the direct load before trying to get the usermodehelper lock? 2. Why is the !NOWAIT case doing a trylock? That seems wrong. --Andy -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/