Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933443AbbLTRQT (ORCPT ); Sun, 20 Dec 2015 12:16:19 -0500 Received: from mail-yk0-f180.google.com ([209.85.160.180]:36120 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932853AbbLTRQR convert rfc822-to-8bit (ORCPT ); Sun, 20 Dec 2015 12:16:17 -0500 MIME-Version: 1.0 In-Reply-To: <566F8148.5020600@gmail.com> References: <1448952881-7871-1-git-send-email-hpeter+linux_kernel@gmail.com> <566F8148.5020600@gmail.com> Date: Sun, 20 Dec 2015 19:16:16 +0200 Message-ID: Subject: Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count for F81504/508/512 From: Andy Shevchenko To: Peter Hung Cc: Greg Kroah-Hartman , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , tom_tsai@fintek.com.tw, Peter H , Peter Hung Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 30 On Tue, Dec 15, 2015 at 4:56 AM, Peter Hung wrote: > Andy Shevchenko 於 2015/12/13 上午 09:08 寫道: >> >> On Tue, Dec 1, 2015 at 8:54 AM, Peter Hung wrote: >>> +/* The device is multi-function with UART & GPIO */ >>> +static u8 fintek_gpio_mapping[] = {2, 3, 8, 9, 10, 11}; >> >> >> Clearly you have bit combination here >> Bit 1: 1 >> Bit 3: 1 >> >> So, mask as 0x0a shall cover this IIAC. > > > IMO, It maybe wrong. If we checked only with 0x0a mask, > the 0x06 & 0x07 will be passed. Ah, yes, it will be a bit more than just one check, something like: (x & 0x0a) && (x & 0x0e != 6) -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/