Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750870AbbLTSNa (ORCPT ); Sun, 20 Dec 2015 13:13:30 -0500 Received: from mail-yk0-f171.google.com ([209.85.160.171]:34108 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbbLTSN2 (ORCPT ); Sun, 20 Dec 2015 13:13:28 -0500 MIME-Version: 1.0 In-Reply-To: References: <1449919416-1980-1-git-send-email-matwey@sai.msu.ru> <1449919416-1980-3-git-send-email-matwey@sai.msu.ru> Date: Sun, 20 Dec 2015 20:13:27 +0200 Message-ID: Subject: Re: [PATCH v5 2/3] tty: Add software emulated RS485 support for 8250 From: Andy Shevchenko To: "Matwey V. Kornilov" Cc: Greg Kroah-Hartman , Jiri Slaby , Peter Hurley , One Thousand Gnomes , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 34 On Sun, Dec 20, 2015 at 8:11 PM, Matwey V. Kornilov wrote: > 2015-12-20 19:41 GMT+03:00 Andy Shevchenko : >> On Sat, Dec 12, 2015 at 1:23 PM, Matwey V. Kornilov wrote: >>> Implementation of software emulation of RS485 direction handling is based >>> on omap_serial driver. >>> Before and after transmission RTS is set to the appropriate value. >>> >>> Note that before calling serial8250_em485_init the caller has to >>> ensure that UART will interrupt when shift register empty. Otherwise, >>> emultaion cannot be used. >>> >>> Both serial8250_em485_init and serial8250_em485_destroy are >>> idempotent functions. >> >> Just nitpick suggesting to rename both struct and field: >> >> struct uart_8250_rs485em *rs485em; > > Why not > > struct uart_8250_em485 *em485; > > to be consistent with function name suffix? I'm fine with that as well. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/