Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751447AbbLUChd (ORCPT ); Sun, 20 Dec 2015 21:37:33 -0500 Received: from mail-vk0-f42.google.com ([209.85.213.42]:35269 "EHLO mail-vk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbbLUChc (ORCPT ); Sun, 20 Dec 2015 21:37:32 -0500 MIME-Version: 1.0 In-Reply-To: <1450451637.19539.11.camel@mtksdaap41> References: <1449824872-18314-1-git-send-email-biao.huang@mediatek.com> <1449824872-18314-5-git-send-email-biao.huang@mediatek.com> <1450451637.19539.11.camel@mtksdaap41> From: Daniel Kurtz Date: Mon, 21 Dec 2015 10:37:09 +0800 X-Google-Sender-Auth: ZxLoRXiD7Idlh4KYUlKBmENWtfY Message-ID: Subject: Re: [PATCH v2 4/5] pinctrl: mediatek: Add Pinctrl/GPIO/EINT driver for mt2701 To: Yingjoe Chen Cc: Biao Huang , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Matthias Brugger , Linus Walleij , "open list:OPEN FIRMWARE AND..." , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, srv_heupstream , Hongzhou Yang , erin.lo@mediatek.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2204 Lines: 66 Hi Biao and Joe, On Fri, Dec 18, 2015 at 11:13 PM, Yingjoe Chen wrote: > On Fri, 2015-12-11 at 17:07 +0800, Biao Huang wrote: >> Add mt2701 support using mediatek common pinctrl driver. >> MT2701 have some special pins need an extra setting register >> than other ICs, so adding this support to common code. >> >> Signed-off-by: Biao Huang >> --- >> drivers/pinctrl/mediatek/Kconfig | 6 + >> drivers/pinctrl/mediatek/Makefile | 1 + >> drivers/pinctrl/mediatek/pinctrl-mt2701.c | 590 +++++++ >> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 14 + >> drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 12 +- >> drivers/pinctrl/mediatek/pinctrl-mtk-mt2701.h | 2323 +++++++++++++++++++++++++ >> 6 files changed, 2945 insertions(+), 1 deletion(-) >> create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt2701.c >> create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt2701.h > > This patch looks good to me. > Thanks > > Acked-by: Yingjoe Chen > > Joe.C > >> >> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig >> index 02f6f92..13e9939 100644 >> --- a/drivers/pinctrl/mediatek/Kconfig >> +++ b/drivers/pinctrl/mediatek/Kconfig >> @@ -9,6 +9,12 @@ config PINCTRL_MTK_COMMON >> select OF_GPIO >> >> # For ARMv7 SoCs >> +config PINCTRL_MT2701 >> + bool "Mediatek MT2701 pin control" if COMPILE_TEST && !MACH_MT2701 This is 'bool', so can never be built as a module... [snip...] >> +module_init(mtk_pinctrl_init); Yingjoe - you just ack'ed this change for the other MTK pinctrl. So, let's apply it here too: -module_init(mtk_pinctrl_init); +arch_initcall(mtk_pinctrl_init); >> + >> +MODULE_LICENSE("GPL v2"); >> +MODULE_DESCRIPTION("MediaTek MT2701 Pinctrl Driver"); >> +MODULE_AUTHOR("Biao Huang "); And remove these lines since this isn't a module. -Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/