Message-ID: <5677AAC4.1010405@rock-chips.com>
Date: Mon, 21 Dec 2015 15:31:16 +0800
From: Mark yao <mark.yao@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Yakir Yang <ykk@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>
CC: David Airlie <airlied@linux.ie>, Thierry Reding <treding@nvidia.com>,
        Rob Herring <robh+dt@kernel.org>, Ken Mixte <kmixter@google.com>,
        Ben Chan <benchan@google.com>, Zheng Yang <zhengyang@rock-chips.com>,
        Kumar Gala <galak@codeaurora.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support
References: <1447227952-4787-1-git-send-email-ykk@rock-chips.com> <1447227999-4842-1-git-send-email-ykk@rock-chips.com>
In-Reply-To: <1447227999-4842-1-git-send-email-ykk@rock-chips.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 937
Lines: 31

On 2015年11月11日 15:46, Yakir Yang wrote:
> +	hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
> +
> +	drm_connector_helper_add(&hdmi->connector,
> +				 &inno_hdmi_connector_helper_funcs);
> +	drm_connector_init(drm, &hdmi->connector, &inno_hdmi_connector_funcs,
> +			   DRM_MODE_CONNECTOR_HDMIA);
> +
> +	hdmi->connector.encoder = encoder;

Pls remove "hdmi->connector.encoder = encoder;"

It would cause a error dump on atomic drm runtime:

WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 
drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200()

This issue can be explained from following thread:
https://lkml.org/lkml/2015/11/16/498

Thanks.

-- 
Ｍark Yao


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/