Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751329AbbLUHeW (ORCPT ); Mon, 21 Dec 2015 02:34:22 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:32876 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbbLUHeV (ORCPT ); Mon, 21 Dec 2015 02:34:21 -0500 MIME-Version: 1.0 In-Reply-To: <1450683132-355-1-git-send-email-ww.tao0320@gmail.com> References: <1450683132-355-1-git-send-email-ww.tao0320@gmail.com> Date: Mon, 21 Dec 2015 15:34:20 +0800 Message-ID: Subject: Re: [PATCH] lightnvm: unlock rq and free ppa_list after submission failed From: Wenwei Tao To: Matias Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1438 Lines: 38 This patch is based on [PATCH] lightnvm: fix bio submission issue https://lkml.org/lkml/2015/12/9/394 2015-12-21 15:32 GMT+08:00 Wenwei Tao : > after io submission failed, before free rq, delete rq from > rrpc's inflight list, leave no bad item in the list. And > free rq's ppa_list to avoid memory leak. > > Signed-off-by: Wenwei Tao > --- > drivers/lightnvm/rrpc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c > index a1e7488..c0886a8 100644 > --- a/drivers/lightnvm/rrpc.c > +++ b/drivers/lightnvm/rrpc.c > @@ -843,6 +843,12 @@ static int rrpc_submit_io(struct rrpc *rrpc, struct bio *bio, > if (err) { > pr_err("rrpc: I/O submission failed: %d\n", err); > bio_put(bio); > + if (!(flags & NVM_IOTYPE_GC)) { > + rrpc_unlock_rq(rrpc, rqd); > + if (rqd->nr_pages > 1) > + nvm_dev_dma_free(rrpc->dev, > + rqd->ppa_list, rqd->dma_ppa_list); > + } > return NVM_IO_ERR; > } > > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/