Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460AbbLUKXc (ORCPT ); Mon, 21 Dec 2015 05:23:32 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:33909 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbbLUKW5 (ORCPT ); Mon, 21 Dec 2015 05:22:57 -0500 Subject: Re: [PATCH V2 21/23] pci, acpi: Support for ACPI based PCI hostbridge init To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1450278993-12664-1-git-send-email-tn@semihalf.com> <1450278993-12664-22-git-send-email-tn@semihalf.com> <2277339.U6fWlSIDzy@wuerfel> Cc: bhelgaas@google.com, will.deacon@arm.com, catalin.marinas@arm.com, rjw@rjwysocki.net, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jiang.liu@linux.intel.com, Stefano.Stabellini@eu.citrix.com, jchandra@broadcom.com, jcm@redhat.com, linaro-acpi@lists.linaro.org, linux-pci@vger.kernel.org, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, robert.richter@caviumnetworks.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, wangyijing@huawei.com, tglx@linutronix.de, mw@semihalf.com From: Tomasz Nowicki Message-ID: <5677D28E.6010803@semihalf.com> Date: Mon, 21 Dec 2015 11:21:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <2277339.U6fWlSIDzy@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1700 Lines: 43 On 18.12.2015 13:40, Arnd Bergmann wrote: > On Wednesday 16 December 2015 16:16:31 Tomasz Nowicki wrote: >> Because of two patch series: >> 1. Jiang Liu's common interface to support PCI host bridge init >> 2. MMCONFIG refactoring (part of this patch set) >> now we can think about generic ACPI based PCI host bridge driver >> out of arch/ directory. >> >> This driver use information from MCFG table (PCI config space regions) >> and _CRS method (IO/irq resources) to initialize PCI hostbridge. >> >> TBD: We are still not sure whether we should reassign resources >> after PCI bus enumeration or trust firmware to do all that work for >> us properly. >> >> Signed-off-by: Tomasz Nowicki >> Signed-off-by: Hanjun Guo >> Signed-off-by: Suravee Suthikulpanit >> CC: Arnd Bergmann >> CC: Catalin Marinas >> CC: Liviu Dudau >> CC: Lorenzo Pieralisi >> CC: Will Deacon >> Tested-by: Suravee Suthikulpanit >> > > I think this code could better live in drivers/acpi/pci_root.c > along with all the related functions. It's not really a driver > by itself and cannot be a loadable module or built on other > architectures. > > You can put all the code inside an #ifdef ARCH_PCI_HOST_GENERIC_ACPI > there. > Makes sense to me, thanks. Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/