Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751457AbbLUNQj (ORCPT ); Mon, 21 Dec 2015 08:16:39 -0500 Received: from mail-ob0-f169.google.com ([209.85.214.169]:33011 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbbLUNQh (ORCPT ); Mon, 21 Dec 2015 08:16:37 -0500 MIME-Version: 1.0 In-Reply-To: References: <1450358557-28376-1-git-send-email-phil.edworthy@renesas.com> <1450358557-28376-3-git-send-email-phil.edworthy@renesas.com> <20151217133058.GA20372@katana> <20151218140412.GA4595@katana> Date: Mon, 21 Dec 2015 14:16:36 +0100 X-Google-Sender-Auth: 9ykQOLVvmX_MFA0nEBtJLFTN5VU Message-ID: Subject: Re: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar From: Geert Uytterhoeven To: Phil Edworthy Cc: Wolfram Sang , Simon Horman , Bjorn Helgaas , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-sh@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 35 Hi Phil, (this time with full CC list) On Mon, Dec 21, 2015 at 11:52 AM, Phil Edworthy wrote: > On 18 December 2015 14:04, Wolfram Sang wrote: >> > Since the hardware doesn't support hot plug, I believe this loop will >> > always exit very quickly. Unless someone has taken a hammer to the HW >> > of course. >> >> I know what you mean. But since readl_poll_timeout() makes it easy, we >> should better be safe than sorry. > Hmm, I changed the code, but now it doesn't come out of suspend unless > sleep_us passed to readl_poll_timeout is 0. Any reason you can think of? Timers or interrupts disabled? Does the might_sleep_if() scream if CONFIG_DEBUG_ATOMIC_SLEEP=y? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/