Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439AbbLUQOY (ORCPT ); Mon, 21 Dec 2015 11:14:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbbLUQOX (ORCPT ); Mon, 21 Dec 2015 11:14:23 -0500 Date: Mon, 21 Dec 2015 17:14:19 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, peterz@infradead.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, namhyung@kernel.org, Andi Kleen Subject: Re: [PATCH 02/10] perf, tools, stat: Force --per-core mode for .agg-per-core aliases Message-ID: <20151221161419.GB21700@krava.brq.redhat.com> References: <1450227266-2501-1-git-send-email-andi@firstfloor.org> <1450227266-2501-3-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450227266-2501-3-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1200 Lines: 29 On Tue, Dec 15, 2015 at 04:54:18PM -0800, Andi Kleen wrote: > From: Andi Kleen > > When an event alias is used that the kernel marked as .agg-per-core, force > --per-core mode (and also require -a and forbid cgroups or per thread mode). > This in term means, --topdown forces --per-core mode. > > This is needed for TopDown in SMT mode, because it needs to measure > all threads in a core together and merge the values to compute the correct > percentages of how the pipeline is limited. > > We do this if any alias is agg-per-core. > > Add the code to parse the .agg-per-core attributes and propagate > the information to the evsel. Then the main stat code does > the necessary checks and forces per core mode. > > Open issue: in combination with -C ... we get wrong values. I think that's > a existing bug that needs to be debugged/fixed separately. could you please be more specific on what's failing for you? thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/