Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751448AbbLURUx (ORCPT ); Mon, 21 Dec 2015 12:20:53 -0500 Received: from smtp618.redcondor.net ([208.80.206.18]:42288 "EHLO smtp618.redcondor.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbbLURUt (ORCPT ); Mon, 21 Dec 2015 12:20:49 -0500 X-RC-FROM: Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel To: Andy Shevchenko , Andy Shevchenko , =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= References: <1450221935-6034-1-git-send-email-mans@mansr.com> <56748D85.4060108@candw.ms> <567541EE.9010308@candw.ms> <56758F33.20804@candw.ms> <5675A84F.2070208@candw.ms> <5675BB2F.6060107@candw.ms> <5675C452.2080206@candw.ms> <5676E906.1060603@candw.ms> <1450716497.30729.232.camel@linux.intel.com> Cc: Tejun Heo , linux-ide@vger.kernel.org, "linux-kernel@vger.kernel.org" From: Julian Margetson Message-ID: <567834DB.4050103@candw.ms> Date: Mon, 21 Dec 2015 13:20:27 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450716497.30729.232.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-DLP-ENABLED: 137.118.22.64/27 X-MAG-OUTBOUND: greymail.redcondor.net@137.118.22.64/27 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2028 Lines: 46 On 12/21/2015 12:48 PM, Andy Shevchenko wrote: > On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: >> On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko >> wrote: >>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård >>> wrote: >>> I noticed thanks to DWC_PARAMS that burst size is hardcoded to 32 >>> items on this board, however registers for SATA program it to 64. I >>> remember that I got no interrupt when I programmed transfer width >>> wrongly (64 bits against 32 bits) when I ported dw_dmac to be used >>> on >>> Intel SoCs. >> One more thing, I have a patch to monitor DMA IO, we may check what >> exactly the values are written / read in DMA. I can share it >> tomorrow. > As promised the patch I have to debug IO of DW DMA. Didn't check though > if it applies cleanly on top of recent vanilla kernel. > patch -p1 -R <../0001-dw_dmac-debug-dma-controller-IO.patch patching file drivers/dma/dw/core.c Hunk #1 succeeded at 543 (offset -27 lines). Hunk #2 FAILED at 1571. Hunk #3 FAILED at 1717. 2 out of 3 hunks FAILED -- saving rejects to file drivers/dma/dw/core.c.rej patching file drivers/dma/dw/regs.h Hunk #1 succeeded at 114 (offset -16 lines). Hunk #2 succeeded at 262 (offset -39 lines). Hunk #3 succeeded at 293 (offset -40 lines). root@julian-VirtualBox:/usr/src/linux-test# patch -p1 <../0001-dw_dmac-debug-dma-controller-IO.patch patching file drivers/dma/dw/core.c Hunk #1 succeeded at 543 (offset -27 lines). Hunk #2 FAILED at 1572. Hunk #3 FAILED at 1716. 2 out of 3 hunks FAILED -- saving rejects to file drivers/dma/dw/core.c.rej patching file drivers/dma/dw/regs.h Hunk #1 succeeded at 114 (offset -16 lines). Hunk #2 succeeded at 264 (offset -39 lines). Hunk #3 succeeded at 307 (offset -40 lines). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/