Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbbLURmy (ORCPT ); Mon, 21 Dec 2015 12:42:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:47634 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbbLURmx (ORCPT ); Mon, 21 Dec 2015 12:42:53 -0500 Date: Mon, 21 Dec 2015 09:42:32 -0800 From: Davidlohr Bueso To: Darren Hart Cc: Thomas Gleixner , Bhuvanesh_Surachari@mentor.com, Peter Zijlstra , Ingo Molnar , Andrew Morton , linux@rasmusvillemoes.dk, viresh.kumar@linaro.org, luto@amacapital.net, Sebastian Sewior , mtk.manpages@gmail.com, LKML , Andy Lowe Subject: Re: [PATCH] futex: Prevent pi_state from double freeing in case of error Message-ID: <20151221174232.GH17386@linux-uzut.site> References: <1450428223-7655-1-git-send-email-Bhuvanesh_Surachari@mentor.com> <20151218145534.GD17386@linux-uzut.site> <20151220052134.GI7244@malice.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20151220052134.GI7244@malice.jf.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 35 On Sat, 19 Dec 2015, Darren Hart wrote: >On Sat, Dec 19, 2015 at 07:24:38PM +0100, Thomas Gleixner wrote: >> - Why are the reviews so sloppy and useless? >> >> The one I'm answering to is just hillarious and the other one picks >> a random commit, claims that it inadvertantly introduced the issue >> and is done with it. Really helpful. >> >> Folks, this is not the way it works. It took me a couple of hours to >> get this analyzed properly, but I don't see that anyone involved in >> this thread has spent more than a few seconds on it. >> >> At least I found a real issue related to this refcount stuff, but I >> would have preferred that the people involved in this would have found >> it in the first place instead of providing half baken crap. >> >> Yours grumpy >> >> tglx > >More care was clearly warranted on my part. I thought I saw the connection with >the previous commit I referenced (it wasn't random!), but clearly didn't dig >deep enough. Same here. I hadn't looked at it long enough, so while I was hesitant of sending a full review/ack, I should not have sent a half-arse answer either. Apologies. Thanks, Davidlohr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/