Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370AbbLUSLf (ORCPT ); Mon, 21 Dec 2015 13:11:35 -0500 Received: from mail-yk0-f176.google.com ([209.85.160.176]:34292 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbbLUSLd (ORCPT ); Mon, 21 Dec 2015 13:11:33 -0500 MIME-Version: 1.0 In-Reply-To: <1450709399-7246-4-git-send-email-aleksey.makarov@linaro.org> References: <1450709399-7246-1-git-send-email-aleksey.makarov@linaro.org> <1450709399-7246-4-git-send-email-aleksey.makarov@linaro.org> Date: Mon, 21 Dec 2015 20:11:32 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] serial: amba-pl011: add ACPI support to AMBA probe From: Andy Shevchenko To: Aleksey Makarov Cc: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , linux-arm Mailing List , Graeme Gregory , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Shannon Zhao , Jiri Slaby Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3268 Lines: 88 On Mon, Dec 21, 2015 at 4:49 PM, Aleksey Makarov wrote: > From: Graeme Gregory > > In ACPI this device is only defined in SBSA mode so > if we are coming from ACPI use this mode. > > Signed-off-by: Graeme Gregory > Signed-off-by: Aleksey Makarov > --- > drivers/tty/serial/amba-pl011.c | 37 ++++++++++++++++++++++++++----------- > 1 file changed, 26 insertions(+), 11 deletions(-) > > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > index 899a771..766ce4f 100644 > --- a/drivers/tty/serial/amba-pl011.c > +++ b/drivers/tty/serial/amba-pl011.c > @@ -2368,18 +2368,33 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id) > if (!uap) > return -ENOMEM; > > - uap->clk = devm_clk_get(&dev->dev, NULL); > - if (IS_ERR(uap->clk)) > - return PTR_ERR(uap->clk); > - > - uap->vendor = vendor; > - uap->lcrh_rx = vendor->lcrh_rx; > - uap->lcrh_tx = vendor->lcrh_tx; > - uap->fifosize = vendor->get_fifosize(dev); > - uap->port.irq = dev->irq[0]; > - uap->port.ops = &amba_pl011_pops; > + /* ACPI only defines SBSA variant */ > + if (ACPI_COMPANION(&dev->dev)) { has_acpi_companion() > + /* > + * According to ARM ARMH0011 is currently the only mapping > + * of pl011 in ACPI and it's mapped to SBSA UART mode > + */ > + uap->vendor = &vendor_sbsa; > + uap->fifosize = 32; > + uap->port.ops = &sbsa_uart_pops; > + uap->fixed_baud = 115200; Shouldn't you match by ID and provide the custom values if any? On the other hand have you checked if it's possible to use _DSD in this case? > > - snprintf(uap->type, sizeof(uap->type), "PL011 rev%u", amba_rev(dev)); > + snprintf(uap->type, sizeof(uap->type), "SBSA"); > + } else { > + uap->clk = devm_clk_get(&dev->dev, NULL); > + if (IS_ERR(uap->clk)) > + return PTR_ERR(uap->clk); > + > + uap->vendor = vendor; > + uap->lcrh_rx = vendor->lcrh_rx; > + uap->lcrh_tx = vendor->lcrh_tx; > + uap->fifosize = vendor->get_fifosize(dev); > + uap->port.ops = &amba_pl011_pops; > + > + snprintf(uap->type, sizeof(uap->type), "PL011 rev%u", > + amba_rev(dev)); > + } > + uap->port.irq = dev->irq[0]; > > ret = pl011_setup_port(&dev->dev, uap, &dev->res, portnr); > if (ret) > -- > 2.6.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/