Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751806AbbLUTgI (ORCPT ); Mon, 21 Dec 2015 14:36:08 -0500 Received: from mga11.intel.com ([192.55.52.93]:11083 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbbLUTgD (ORCPT ); Mon, 21 Dec 2015 14:36:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,460,1444719600"; d="scan'208";a="876184413" Message-ID: <1450726452.30729.259.camel@linux.intel.com> Subject: Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain From: Andy Shevchenko To: Mans Rullgard , Viresh Kumar , Dan Williams , Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 21 Dec 2015 21:34:12 +0200 In-Reply-To: <1450725037-26492-1-git-send-email-mans@mansr.com> References: <1450725037-26492-1-git-send-email-mans@mansr.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1453 Lines: 44 On Mon, 2015-12-21 at 19:10 +0000, Mans Rullgard wrote: > The datasheet requires that the LLP_[SD]_EN bits be cleared whenever > LLP.LOC is zero, i.e. in the last descriptor of a multi-block chain. > Make the driver do this. Acked-by: Andy Shevchenko > > Signed-off-by: Mans Rullgard > --- >  drivers/dma/dw/core.c | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c > index 7067b6ddc1db..ca7cafc82f6b 100644 > --- a/drivers/dma/dw/core.c > +++ b/drivers/dma/dw/core.c > @@ -751,6 +751,7 @@ dwc_prep_dma_memcpy(struct dma_chan *chan, > dma_addr_t dest, dma_addr_t src, >   prev->lli.ctllo |= DWC_CTLL_INT_EN; >   >   prev->lli.llp = 0; > + prev->lli.ctllo &= ~(DWC_CTLL_LLP_D_EN | DWC_CTLL_LLP_S_EN); >   first->txd.flags = flags; >   first->total_len = len; >   > @@ -912,6 +913,7 @@ slave_sg_fromdev_fill_desc: >   prev->lli.ctllo |= DWC_CTLL_INT_EN; >   >   prev->lli.llp = 0; > + prev->lli.ctllo &= ~(DWC_CTLL_LLP_D_EN | DWC_CTLL_LLP_S_EN); >   first->total_len = total_len; >   >   return &first->txd; -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/