Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbbLUVCh (ORCPT ); Mon, 21 Dec 2015 16:02:37 -0500 Received: from mail-oi0-f47.google.com ([209.85.218.47]:33629 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbbLUVCf (ORCPT ); Mon, 21 Dec 2015 16:02:35 -0500 MIME-Version: 1.0 In-Reply-To: References: <1450709399-7246-1-git-send-email-aleksey.makarov@linaro.org> <1450709399-7246-4-git-send-email-aleksey.makarov@linaro.org> Date: Mon, 21 Dec 2015 21:02:34 +0000 Message-ID: Subject: Re: [PATCH v2 3/3] serial: amba-pl011: add ACPI support to AMBA probe From: G Gregory To: Andy Shevchenko Cc: Aleksey Makarov , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , linux-arm Mailing List , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Shannon Zhao , Jiri Slaby Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2404 Lines: 59 On 21 December 2015 at 18:11, Andy Shevchenko wrote: > On Mon, Dec 21, 2015 at 4:49 PM, Aleksey Makarov > wrote: >> From: Graeme Gregory >> >> In ACPI this device is only defined in SBSA mode so >> if we are coming from ACPI use this mode. >> >> Signed-off-by: Graeme Gregory >> Signed-off-by: Aleksey Makarov >> --- >> drivers/tty/serial/amba-pl011.c | 37 ++++++++++++++++++++++++++----------- >> 1 file changed, 26 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c >> index 899a771..766ce4f 100644 >> --- a/drivers/tty/serial/amba-pl011.c >> +++ b/drivers/tty/serial/amba-pl011.c >> @@ -2368,18 +2368,33 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id) >> if (!uap) >> return -ENOMEM; >> >> - uap->clk = devm_clk_get(&dev->dev, NULL); >> - if (IS_ERR(uap->clk)) >> - return PTR_ERR(uap->clk); >> - >> - uap->vendor = vendor; >> - uap->lcrh_rx = vendor->lcrh_rx; >> - uap->lcrh_tx = vendor->lcrh_tx; >> - uap->fifosize = vendor->get_fifosize(dev); >> - uap->port.irq = dev->irq[0]; >> - uap->port.ops = &amba_pl011_pops; >> + /* ACPI only defines SBSA variant */ >> + if (ACPI_COMPANION(&dev->dev)) { > > has_acpi_companion() > >> + /* >> + * According to ARM ARMH0011 is currently the only mapping >> + * of pl011 in ACPI and it's mapped to SBSA UART mode >> + */ >> + uap->vendor = &vendor_sbsa; >> + uap->fifosize = 32; >> + uap->port.ops = &sbsa_uart_pops; >> + uap->fixed_baud = 115200; > > Shouldn't you match by ID and provide the custom values if any? > On the other hand have you checked if it's possible to use _DSD in this case? > So far I have not seen any use of SBSA UART other than this in real life. I am a little opposed to providing complexity people are not going to use. Graeme -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/