Date: Mon, 21 Dec 2015 14:08:25 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Simmons <jsimmons@infradead.org>
Cc: devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        James Simmons <uja.ornl@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        lustre-devel@lists.lustre.org
Subject: Re: [PATCH] staging: lustre: Handle nodemask on UMP machines
Message-ID: <20151221220825.GC14211@kroah.com>
References: <1447000500-29427-1-git-send-email-jsimmons@infradead.org>
 <1447000500-29427-2-git-send-email-jsimmons@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447000500-29427-2-git-send-email-jsimmons@infradead.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1994
Lines: 48

On Sun, Nov 08, 2015 at 11:34:55AM -0500, James Simmons wrote:
> For UMP and SMP machines the struct cfs_cpt_table are
> defined differently. In the case handled by this patch
> nodemask is defined as a integer for the UMP case and
> as a pointer for the SMP case. This will cause a problem
> for ost_setup which reads the nodemask directly. Instead
> we create a UMP version of cfs_cpt_nodemask and use that
> in ost_setup.
> 
> Signed-off-by: James Simmons <uja.ornl@gmail.com>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4199
> Reviewed-on: http://review.whamcloud.com/9219
> Reviewed-by: Liang Zhen <liang.zhen@intel.com>
> Reviewed-by: Li Xi <pkuelelixi@gmail.com>
> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> 
> Starting in 3.14 kernels nodemask_t was changed from a
> a unsigned long to a linux bitmap so more than 32 cores
> could be supported. Using set_bit in cfs_cpt_table_alloc
> no longer compiles so this patch backports bits of the
> node management function that use a linux bitmap back
> end. Cleaned up libcfs bitmap.h to use the libcfs layers
> memory allocation function. This was pulling in lustre
> related code that was not defined.
> 
> Signed-off-by: James Simmons <uja.ornl@gmail.com>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4993
> Reviewed-on: http://review.whamcloud.com/10332
> Reviewed-by: Liang Zhen <liang.zhen@intel.com>
> Reviewed-by: Bob Glossman <bob.glossman@intel.com>
> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>

What is with this crazy two sections of signed-off-by?  If this was 2
patches, make it two patches.

If not, then don't do this.

Also, this whole series had no numbering, so I don't know how to apply
them, please fix and resend it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/