Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbbLUXpA (ORCPT ); Mon, 21 Dec 2015 18:45:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45317 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbbLUXo7 (ORCPT ); Mon, 21 Dec 2015 18:44:59 -0500 Date: Mon, 21 Dec 2015 15:44:43 -0800 From: Greg Kroah-Hartman To: Niranjan Dighe Cc: Oleg Drokin , Andreas Dilger , Dmitry Eremin , James Simmons , Mike Rapoport , Patrick Boettcher , Matthew Tyler , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Subject: Re: [PATCH] staging: lustre/lustre/libcfs: Fix type mismatch reported by sparse Message-ID: <20151221234443.GA11245@kroah.com> References: <20151209170813.GA12216@codebox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151209170813.GA12216@codebox> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 32 On Wed, Dec 09, 2015 at 10:38:13PM +0530, Niranjan Dighe wrote: > The third argument to function kportal_memhog_alloc is expected to > be gfp_t whereas the actual argument was unsigned int. Fix this by > explicitly typecasting to gfp_t > > Signed-off-by: Niranjan Dighe > --- > drivers/staging/lustre/lustre/libcfs/module.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c > index 96d9d46..9c79f6e 100644 > --- a/drivers/staging/lustre/lustre/libcfs/module.c > +++ b/drivers/staging/lustre/lustre/libcfs/module.c > @@ -268,7 +268,7 @@ static int libcfs_ioctl_int(struct cfs_psdev_file *pfile, unsigned long cmd, > /* XXX The ioc_flags is not GFP flags now, need to be fixed */ > err = kportal_memhog_alloc(pfile->private_data, > data->ioc_count, > - data->ioc_flags); > + (__force gfp_t)data->ioc_flags); No, please fix the type to be correct properly, like the comment says needs to be done. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/