Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbbLVAaZ (ORCPT ); Mon, 21 Dec 2015 19:30:25 -0500 Received: from mleia.com ([178.79.152.223]:50841 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbbLVAaX (ORCPT ); Mon, 21 Dec 2015 19:30:23 -0500 Message-ID: <5678999C.7040808@mleia.com> Date: Tue, 22 Dec 2015 02:30:20 +0200 From: Vladimir Zapolskiy User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Cory Tusar , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, gregkh@linuxfoundation.org CC: jic23@kernel.org, broonie@kernel.org, afd@ti.com, andrew@lunn.ch, Chris.Healy@zii.aero, Keith.Vennel@zii.aero, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. References: <1449720055-25965-1-git-send-email-cory.tusar@pid1solutions.com> <1449720055-25965-6-git-send-email-cory.tusar@pid1solutions.com> In-Reply-To: <1449720055-25965-6-git-send-email-cory.tusar@pid1solutions.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20151222_003034_977572_AAE62B71 X-CRM114-Status: GOOD ( 26.86 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3764 Lines: 120 Hi Cory, On 10.12.2015 06:00, Cory Tusar wrote: > This commit adds support to the eeprom_93x46 driver allowing a GPIO line > to function as a 'select' or 'enable' signal prior to accessing the > EEPROM. > > Signed-off-by: Cory Tusar > Tested-by: Chris Healy > --- > drivers/misc/eeprom/eeprom_93xx46.c | 35 +++++++++++++++++++++++++++++++++++ > include/linux/eeprom_93xx46.h | 3 +++ > 2 files changed, 38 insertions(+) > > diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c > index d50bc17..d28fac2 100644 > --- a/drivers/misc/eeprom/eeprom_93xx46.c > +++ b/drivers/misc/eeprom/eeprom_93xx46.c > @@ -10,11 +10,13 @@ > > #include > #include > +#include > #include > #include > #include > #include > #include > +#include > #include > #include > #include > @@ -343,6 +345,20 @@ static ssize_t eeprom_93xx46_store_erase(struct device *dev, > } > static DEVICE_ATTR(erase, S_IWUSR, NULL, eeprom_93xx46_store_erase); > > +static void select_assert(void *context) > +{ > + struct eeprom_93xx46_dev *edev = context; > + > + gpiod_set_value_cansleep(edev->pdata->select, 1); > +} > + > +static void select_deassert(void *context) > +{ > + struct eeprom_93xx46_dev *edev = context; > + > + gpiod_set_value_cansleep(edev->pdata->select, 0); > +} > + > static const struct of_device_id eeprom_93xx46_of_table[] = { > { .compatible = "eeprom-93xx46", }, > { .compatible = "atmel,at93c46d", .data = &atmel_at93c46d_data, }, > @@ -357,6 +373,8 @@ static int eeprom_93xx46_probe_dt(struct spi_device *spi) > struct device_node *np = spi->dev.of_node; > struct eeprom_93xx46_platform_data *pd; > u32 tmp; > + int gpio; > + enum of_gpio_flags of_flags; > int ret; > > pd = devm_kzalloc(&spi->dev, sizeof(*pd), GFP_KERNEL); > @@ -381,6 +399,23 @@ static int eeprom_93xx46_probe_dt(struct spi_device *spi) > if (of_property_read_bool(np, "read-only")) > pd->flags |= EE_READONLY; > > + gpio = of_get_named_gpio_flags(np, "select-gpios", 0, &of_flags); > + if (gpio_is_valid(gpio)) { > + unsigned long flags = > + of_flags == OF_GPIO_ACTIVE_LOW ? GPIOF_ACTIVE_LOW : 0; > + > + ret = devm_gpio_request_one(&spi->dev, gpio, flags, > + "eeprom_93xx46_select"); > + if (ret) > + return ret; > + > + pd->select = gpio_to_desc(gpio); > + pd->prepare = select_assert; > + pd->finish = select_deassert; > + > + gpiod_direction_output(pd->select, 0); > + } > + > if (of_id->data) { > const struct eeprom_93xx46_devtype_data *data = of_id->data; > > diff --git a/include/linux/eeprom_93xx46.h b/include/linux/eeprom_93xx46.h > index 92fa4c3..03f3435 100644 > --- a/include/linux/eeprom_93xx46.h > +++ b/include/linux/eeprom_93xx46.h > @@ -3,6 +3,8 @@ > * platform description for 93xx46 EEPROMs. > */ > > +#include > + You need just "struct gpio_desc;" instead of the include here, please fix. > struct eeprom_93xx46_platform_data { > unsigned char flags; > #define EE_ADDR8 0x01 /* 8 bit addr. cfg */ > @@ -21,4 +23,5 @@ struct eeprom_93xx46_platform_data { > */ > void (*prepare)(void *); > void (*finish)(void *); > + struct gpio_desc *select; > }; > Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/