Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752362AbbLVAbF (ORCPT ); Mon, 21 Dec 2015 19:31:05 -0500 Received: from mga11.intel.com ([192.55.52.93]:53943 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbbLVAbD convert rfc822-to-8bit (ORCPT ); Mon, 21 Dec 2015 19:31:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,461,1444719600"; d="scan'208";a="876343552" From: "Dilger, Andreas" To: James Simmons CC: "devel@driverdev.osuosl.org" , James Simmons , Linux Kernel Mailing List , "Drokin, Oleg" , "lustre-devel@lists.lustre.org" , "Greg Kroah-Hartman" Subject: Re: [lustre-devel] [PATCH] staging: lustre: Handle nodemask on UMP machines Thread-Topic: [lustre-devel] [PATCH] staging: lustre: Handle nodemask on UMP machines Thread-Index: AQHRPE/zOsR9NANuBkGkAMM79HQRpA== Date: Tue, 22 Dec 2015 00:30:24 +0000 Message-ID: References: <1447000500-29427-1-git-send-email-jsimmons@infradead.org> <1447000500-29427-2-git-send-email-jsimmons@infradead.org> <20151221220825.GC14211@kroah.com> In-Reply-To: <20151221220825.GC14211@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.42.130] Content-Type: text/plain; charset="us-ascii" Content-ID: <28D7A272339D034E8F9C0D65FDB2FFA2@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2646 Lines: 65 On 2015/12/21, 15:08, "lustre-devel on behalf of Greg Kroah-Hartman" wrote: >On Sun, Nov 08, 2015 at 11:34:55AM -0500, James Simmons wrote: >> For UMP and SMP machines the struct cfs_cpt_table are >> defined differently. In the case handled by this patch >> nodemask is defined as a integer for the UMP case and >> as a pointer for the SMP case. This will cause a problem >> for ost_setup which reads the nodemask directly. Instead >> we create a UMP version of cfs_cpt_nodemask and use that >> in ost_setup. >> >> Signed-off-by: James Simmons >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4199 >> Reviewed-on: http://review.whamcloud.com/9219 >> Reviewed-by: Liang Zhen >> Reviewed-by: Li Xi >> Reviewed-by: Andreas Dilger >> >> Starting in 3.14 kernels nodemask_t was changed from a >> a unsigned long to a linux bitmap so more than 32 cores >> could be supported. Using set_bit in cfs_cpt_table_alloc >> no longer compiles so this patch backports bits of the >> node management function that use a linux bitmap back >> end. Cleaned up libcfs bitmap.h to use the libcfs layers >> memory allocation function. This was pulling in lustre >> related code that was not defined. >> >> Signed-off-by: James Simmons >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4993 >> Reviewed-on: http://review.whamcloud.com/10332 >> Reviewed-by: Liang Zhen >> Reviewed-by: Bob Glossman >> Reviewed-by: Oleg Drokin > >What is with this crazy two sections of signed-off-by? If this was 2 >patches, make it two patches. > >If not, then don't do this. > >Also, this whole series had no numbering, so I don't know how to apply >them, please fix and resend it. I suspect that this is merging two separate patches so that they do not introduce a regression when landed to master. In the past you've said you wanted fix patches merged into the original patch for this reason. I guess the right thing to do is to merge the Signed-off-by: lines at the end of the combined patch, rather than just mashing the commit messages together. Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel High Performance Data Division -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/