Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbbLVCsx (ORCPT ); Mon, 21 Dec 2015 21:48:53 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:17984 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899AbbLVCsr (ORCPT ); Mon, 21 Dec 2015 21:48:47 -0500 Subject: Re: [PATCH] IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support. To: Marc Zyngier References: <1450667905-2968-1-git-send-email-majun258@huawei.com> <20151221104358.18734bc3@why.wild-wind.fr.eu.org> CC: , , , , , , , , , , , , , , From: "majun (F)" Message-ID: <5678B9A0.8050506@huawei.com> Date: Tue, 22 Dec 2015 10:46:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20151221104358.18734bc3@why.wild-wind.fr.eu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.235.245] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.5678B9BB.0193,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 40b3192228ad9a3614cad7986b0d2671 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 54 在 2015/12/21 18:43, Marc Zyngier 写道: > On Mon, 21 Dec 2015 11:18:25 +0800 > MaJun wrote: > >> From: Ma Jun >> >> The current MSI framework can only support 256 platform MSIs. >> >> But on Hisilicon platform, some network related devices has about 500 >> wired interrupts. >> >> To support these devices, we need a new maximum value more than 256. >> >> Signed-off-by: Ma Jun >> --- >> drivers/base/platform-msi.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c >> index a203896..9c00d3f 100644 >> --- a/drivers/base/platform-msi.c >> +++ b/drivers/base/platform-msi.c >> @@ -24,7 +24,7 @@ >> #include >> #include >> >> -#define DEV_ID_SHIFT 24 >> +#define DEV_ID_SHIFT 22 >> #define MAX_DEV_MSIS (1 << (32 - DEV_ID_SHIFT)) >> >> /* > > If we bother doing that, why not directly aligning it with MSI-X and > allow up to 2048 interrupts per device? It is only an extra bit, and > that still leaves 21 bits worth of device IDs, while still having > hwirq as an unsigned long (32bit on 32bit architectures). > Ok, I'll changed this value to 2048 Thanks Ma Jun > Thanks, > > M. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/