Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbbLVDKe (ORCPT ); Mon, 21 Dec 2015 22:10:34 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:41661 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbbLVDK3 (ORCPT ); Mon, 21 Dec 2015 22:10:29 -0500 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: kyeongdon.kim@lge.com X-Original-SENDERIP: 10.168.83.150 X-Original-MAILFROM: kyeongdon.kim@lge.com Subject: Re: Re: [PATCH v4 2/2] zram: try vmalloc() after kmalloc() To: Sergey Senozhatsky References: <1448973390-21170-1-git-send-email-sergey.senozhatsky@gmail.com> <20151218002829.GA4809@swordfish> Cc: Andrew Morton , Minchan Kim , linux-kernel@vger.kernel.org From: Kyeongdon Kim Message-ID: <5678BF21.9010504@lge.com> Date: Tue, 22 Dec 2015 12:10:25 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151218002829.GA4809@swordfish> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6273 Lines: 178 On 2015-12-18 오전 9:28, Sergey Senozhatsky wrote: > On (12/01/15 21:36), Sergey Senozhatsky wrote: >> When we're using LZ4 multi compression streams for zram swap, we found > out >> page allocation failure message in system running test. That was not only >> once, but a few(2 - 5 times per test). Also, some failure cases were >> continually occurring to try allocation order 3. >> >> In order to make parallel compression private data, we should call >> kzalloc() with order 2/3 in runtime(lzo/lz4). But if there is no order >> 2/3 size memory to allocate in that time, page allocation fails. This >> patch makes to use vmalloc() as fallback of kmalloc(), this prevents page >> alloc failure warning. >> >> After using this, we never found warning message in running test, also It >> could reduce process startup latency about 60-120ms in each case. >> > > Hello Kyeongdon, > > just to make sure, the patch works fine for you and we can move > forward and Cc -stable. correct? > > -ss > Hello Sergey, I was on vacation so I checked your email a moment ago, sorry about it. We're using this patch set. and we couldn't find any issue from this one until now. Thanks, Kyeongdon Kim >> For reference a call trace : >> >> Binder_1: page allocation failure: order:3, mode:0x10c0d0 >> CPU: 0 PID: 424 Comm: Binder_1 Tainted: GW 3.10.49-perf-g991d02b-dirty > #20 >> Call trace: >> [] dump_backtrace+0x0/0x270 >> [] show_stack+0x10/0x1c >> [] dump_stack+0x1c/0x28 >> [] warn_alloc_failed+0xfc/0x11c >> [] __alloc_pages_nodemask+0x724/0x7f0 >> [] __get_free_pages+0x14/0x5c >> [] kmalloc_order_trace+0x38/0xd8 >> [] zcomp_lz4_create+0x2c/0x38 >> [] zcomp_strm_alloc+0x34/0x78 >> [] zcomp_strm_multi_find+0x124/0x1ec >> [] zcomp_strm_find+0xc/0x18 >> [] zram_bvec_rw+0x2fc/0x780 >> [] zram_make_request+0x25c/0x2d4 >> [] generic_make_request+0x80/0xbc >> [] submit_bio+0xa4/0x15c >> [] __swap_writepage+0x218/0x230 >> [] swap_writepage+0x3c/0x4c >> [] shrink_page_list+0x51c/0x8d0 >> [] shrink_inactive_list+0x3f8/0x60c >> [] shrink_lruvec+0x33c/0x4cc >> [] shrink_zone+0x3c/0x100 >> [] try_to_free_pages+0x2b8/0x54c >> [] __alloc_pages_nodemask+0x514/0x7f0 >> [] __get_free_pages+0x14/0x5c >> [] proc_info_read+0x50/0xe4 >> [] vfs_read+0xa0/0x12c >> [] SyS_read+0x44/0x74 >> DMA: 3397*4kB (MC) 26*8kB (RC) 0*16kB 0*32kB 0*64kB 0*128kB 0*256kB >> 0*512kB 0*1024kB 0*2048kB 0*4096kB = 13796kB >> >> [minchan@kernel.org: change vmalloc gfp and adding comment about gfp] >> [sergey.senozhatsky@gmail.com: tweak comments and styles] >> Signed-off-by: Kyeongdon Kim >> Signed-off-by: Minchan Kim >> Acked-by: Sergey Senozhatsky >> --- >> drivers/block/zram/zcomp_lz4.c | 23 +++++++++++++++++++++-- >> drivers/block/zram/zcomp_lzo.c | 23 +++++++++++++++++++++-- >> 2 files changed, 42 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/block/zram/zcomp_lz4.c > b/drivers/block/zram/zcomp_lz4.c >> index ee44b51..dd60831 100644 >> --- a/drivers/block/zram/zcomp_lz4.c >> +++ b/drivers/block/zram/zcomp_lz4.c >> @@ -10,17 +10,36 @@ >> #include >> #include >> #include >> +#include >> +#include >> >> #include "zcomp_lz4.h" >> >> static void *zcomp_lz4_create(void) >> { >> - return kzalloc(LZ4_MEM_COMPRESS, GFP_NOIO); >> + void *ret; >> + >> + /* >> + * This function can be called in swapout/fs write path >> + * so we can't use GFP_FS|IO. And it assumes we already >> + * have at least one stream in zram initialization so we >> + * don't do best effort to allocate more stream in here. >> + * A default stream will work well without further multiple >> + * streams. That's why we use NORETRY | NOWARN. >> + */ >> + ret = kzalloc(LZ4_MEM_COMPRESS, GFP_NOIO | __GFP_NORETRY | >> + __GFP_NOWARN); >> + if (!ret) >> + ret = __vmalloc(LZ4_MEM_COMPRESS, >> + GFP_NOIO | __GFP_NORETRY | __GFP_NOWARN | >> + __GFP_ZERO | __GFP_HIGHMEM, >> + PAGE_KERNEL); >> + return ret; >> } >> >> static void zcomp_lz4_destroy(void *private) >> { >> - kfree(private); >> + kvfree(private); >> } >> >> static int zcomp_lz4_compress(const unsigned char *src, unsigned char > *dst, >> diff --git a/drivers/block/zram/zcomp_lzo.c > b/drivers/block/zram/zcomp_lzo.c >> index 683ce04..edc5499 100644 >> --- a/drivers/block/zram/zcomp_lzo.c >> +++ b/drivers/block/zram/zcomp_lzo.c >> @@ -10,17 +10,36 @@ >> #include >> #include >> #include >> +#include >> +#include >> >> #include "zcomp_lzo.h" >> >> static void *lzo_create(void) >> { >> - return kzalloc(LZO1X_MEM_COMPRESS, GFP_NOIO); >> + void *ret; >> + >> + /* >> + * This function can be called in swapout/fs write path >> + * so we can't use GFP_FS|IO. And it assumes we already >> + * have at least one stream in zram initialization so we >> + * don't do best effort to allocate more stream in here. >> + * A default stream will work well without further multiple >> + * streams. That's why we use NORETRY | NOWARN. >> + */ >> + ret = kzalloc(LZO1X_MEM_COMPRESS, GFP_NOIO | __GFP_NORETRY | >> + __GFP_NOWARN); >> + if (!ret) >> + ret = __vmalloc(LZO1X_MEM_COMPRESS, >> + GFP_NOIO | __GFP_NORETRY | __GFP_NOWARN | >> + __GFP_ZERO | __GFP_HIGHMEM, >> + PAGE_KERNEL); >> + return ret; >> } >> >> static void lzo_destroy(void *private) >> { >> - kfree(private); >> + kvfree(private); >> } >> >> static int lzo_compress(const unsigned char *src, unsigned char *dst, >> -- >> 2.6.2 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/