Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S262186AbTCHT77>; Sat, 8 Mar 2003 14:59:59 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S262187AbTCHT77>; Sat, 8 Mar 2003 14:59:59 -0500
Received: from 12-231-249-244.client.attbi.com ([12.231.249.244]:39950 "HELO
	kroah.com") by vger.kernel.org with SMTP id <S262186AbTCHT7y>;
	Sat, 8 Mar 2003 14:59:54 -0500
Date: Sat, 8 Mar 2003 12:00:16 -0800
From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@infradead.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Andrew Morton <akpm@digeo.com>, Andries.Brouwer@cwi.nl,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCH] register_blkdev
Message-ID: <20030308200016.GF26374@kroah.com>
References: <20030307193644.A14196@infradead.org> <20030307123029.2bc91426.akpm@digeo.com> <20030307221217.GB21315@kroah.com> <20030307143319.2413d1df.akpm@digeo.com> <20030307234541.GG21315@kroah.com> <1047086062.24215.14.camel@irongate.swansea.linux.org.uk> <20030308005018.GE23071@kroah.com> <1047136302.25932.28.camel@irongate.swansea.linux.org.uk> <20030308193722.GD26374@kroah.com> <20030308195028.A31394@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030308195028.A31394@infradead.org>
User-Agent: Mutt/1.4i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1165
Lines: 25

On Sat, Mar 08, 2003 at 07:50:28PM +0000, Christoph Hellwig wrote:
> On Sat, Mar 08, 2003 at 11:37:22AM -0800, Greg KH wrote:
> > That's a good start, but why not change that to a simple,
> > HOW_MANY_MINORS_I_WANT, which will work the same way now, but allow us
> > to change to a pure dynamic major/minor allocation scheme in the future
> > by only modifying the register_chr_device() code.  Same thing for
> > register_blkdev().
> 
> register_blkdev() _IS_ totally meaningless in 2.5.  I said this about three
> times in this thread already, when will people actually take a look at
> the code they look at?

I've looked at it, and right now it keeps drivers from registering the
same major number, and provides a pretty string for the requested major,
when the kernel wants to print it out.

Yes, most of the old code and logic is now gone, but can you just remove
the call altogether now?  If so, great :)

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/