Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933131AbbLVTEb (ORCPT ); Tue, 22 Dec 2015 14:04:31 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36173 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933079AbbLVTEZ (ORCPT ); Tue, 22 Dec 2015 14:04:25 -0500 Date: Mon, 21 Dec 2015 21:09:25 -0800 From: Olof Johansson To: Valentin Rothberg Cc: arnd@arndb.de, fengguang.wu@intel.com, arm@kernel.org, linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com Subject: Re: [PATCH] iio: exynos-adc: fix irqf_oneshot.cocci warnings Message-ID: <20151222050925.GL30172@localhost> References: <20151202084310.GA4665@debian-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151202084310.GA4665@debian-vm> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 27 On Wed, Dec 02, 2015 at 09:43:10AM +0100, Valentin Rothberg wrote: > Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") > threaded IRQs without a primary handler need to be requested with > IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci > > Signed-off-by: Fengguang Wu > Signed-off-by: Valentin Rothberg > --- > > The patch looks fine to me: bad things can happen when interrupts are > acked before the handler ran. Hi, Applied. Thanks. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/